Skip to content

[enterprise-4.14] OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage #75331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcarmichael08 merged 1 commit into from
May 13, 2024
Merged

[enterprise-4.14] OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage #75331

kcarmichael08 merged 1 commit into from
May 13, 2024

Conversation

@sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Apr 30, 2024 •
edited
Loading

Version(s):
4.14

Issue:
OCPBUGS-33114

Link to docs preview:
Preview

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2024
@sr1kar99 sr1kar99 changed the title OCPBUGS#33114: Doc improvements related to metrics, must-gather, and … OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage Apr 30, 2024
@sr1kar99 sr1kar99 changed the title OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage [enterprise-4.14] OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage Apr 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 30, 2024 •
edited
Loading

🤖 Mon May 13 18:20:35 - Prow CI generated the docs preview:

https://75331--ocpdocs-pr.netlify.app/
https://75331--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

@sr1kar99 sr1kar99 force-pushed the 33114-metrics-doc-improv branch from df3cb40 to ec35b85 Compare April 30, 2024 08:00
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 6, 2024

@suleymanakbas91
Could you please review this PR?
Thanks!

@suleymanakbas91
Copy link

suleymanakbas91 commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

@radeore
Can you please review this PR?
Thanks!

@radeore
Copy link

radeore commented May 9, 2024

/lgtm

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 10, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 10, 2024
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 10, 2024
jeana-redhat
jeana-redhat reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancements! :)

One question about version applibaility: this says 4.14, but the bug it's addressing says 4.13, 4.14. Can you confirm which version(s) this impacts?

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 10, 2024
@jeana-redhat jeana-redhat mentioned this pull request May 10, 2024
Merged
1 task
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 11, 2024

Nice enhancements! :)

One question about version applibaility: this says 4.14, but the bug it's addressing says 4.13, 4.14. Can you confirm which version(s) this impacts?

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

@jeana-redhat
Thanks for the review! :)

Yes! You are right. I will be creating another PR for 4.13 after closing the PRs for 4.14 doc improvements.

@sr1kar99 sr1kar99 force-pushed the 33114-metrics-doc-improv branch from ec35b85 to cb4bde5 Compare May 11, 2024 13:04
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2024

New changes are detected. LGTM label has been removed.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 13, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 13, 2024
@sr1kar99 sr1kar99 force-pushed the 33114-metrics-doc-improv branch from cb4bde5 to eeed35b Compare May 13, 2024 14:48
@jab-rh jab-rh added this to the Continuous Release milestone May 13, 2024
@jab-rh
Copy link
Contributor

jab-rh commented May 13, 2024

@sr1kar99, looks like this conflicts with the other PR and needs a conflict resolution.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 13, 2024

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 13, 2024
@sr1kar99 sr1kar99 force-pushed the 33114-metrics-doc-improv branch from eeed35b to b065464 Compare May 13, 2024 17:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 13, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 13, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 13, 2024

@sr1kar99, looks like this conflicts with the other PR and needs a conflict resolution.

@jab-rh Resolved the conflicts. Could you please merge this PR?
Thanks!

@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 13, 2024
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented May 13, 2024

lgtm for merge

@kcarmichael08 kcarmichael08 merged commit e563683 into openshift:enterprise-4.14 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

Assignees

@suleymanakbas91 suleymanakbas91

@radeore radeore

Labels

branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@sr1kar99 @ocpdocs-previewbot @suleymanakbas91 @radeore @jab-rh @ShaunaDiaz @kcarmichael08 @jeana-redhat @openshift-merge-robot