Skip to content

Conversation

@stevsmit
Copy link
Member

@stevsmit stevsmit commented Jun 5, 2024

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from e185d9a to 8822149 Compare June 5, 2024 18:10
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from 8822149 to 748d1d6 Compare June 5, 2024 18:25
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch 4 times, most recently from 68b5119 to e8392a6 Compare June 5, 2024 19:57
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from e8392a6 to f904229 Compare June 7, 2024 13:55
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch 2 times, most recently from 908d9e3 to f277a43 Compare June 7, 2024 14:13
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from f277a43 to 4e52cfb Compare June 10, 2024 17:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch 2 times, most recently from 72726e8 to 758df6b Compare June 11, 2024 18:23
@stevsmit stevsmit added this to the Planned for 4.16 GA milestone Jun 18, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch 2 times, most recently from 145c7ce to 06261ff Compare June 20, 2024 13:46
@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 20, 2024
@stevsmit stevsmit removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 20, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch 2 times, most recently from c8c68de to 0fb6dcc Compare June 20, 2024 14:10
@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 20, 2024
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 20, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits for ya - overall looking great 🤓

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 20, 2024
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from 0fb6dcc to 8721bdc Compare June 20, 2024 17:36
@stevsmit stevsmit force-pushed the live-migration-rollback-updates-10662 branch from 8721bdc to 0462085 Compare June 20, 2024 17:39
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2024

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor

pliurh commented Jun 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@weliang1
Copy link

/lgtm

@stevsmit stevsmit merged commit 0a3d8c0 into openshift:main Jun 21, 2024
@stevsmit
Copy link
Member Author

/cherry-pick enterprise-4.16

@openshift-cherrypick-robot

@stevsmit: new pull request created: #77862

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants