Skip to content

Conversation

@stevsmit
Copy link
Member

@stevsmit stevsmit commented Aug 29, 2024

This is a manual cherry-pick of #77067, which is CP'd from 0462085. The content of this PR will not exactly match the PR which it was CP'd from, though it should be close. Because of various changes to the docs since this content went live (which are difficult to track), I used this original PR as a base and then copied the docs from version 4.16. That being said, discrepancies between this PR and the one that it was cherry-picked from are expected (if you compare the two, I mean).

This is PR one of 2. The second is #81120

The content matches its "parent content" in version 4.16.

Jira: https://issues.redhat.com/browse/OSDOCS-11834

For 4.15 only.

Preview:

https://81099--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/rollback-to-openshift-sdn.html

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2024
@stevsmit stevsmit force-pushed the OSDOCS-11834-limited-live-migration-backport branch from 6afc854 to 5c12538 Compare August 29, 2024 14:23
@stevsmit stevsmit force-pushed the OSDOCS-11834-limited-live-migration-backport branch from 5c12538 to 7cc7abe Compare August 29, 2024 14:31
@stevsmit stevsmit force-pushed the OSDOCS-11834-limited-live-migration-backport branch from 7cc7abe to e2a975c Compare August 29, 2024 14:58
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2024

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@pliurh
Copy link
Contributor

pliurh commented Oct 11, 2024

LGTM

@stevsmit stevsmit added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 11, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 11, 2024
@adellape adellape self-assigned this Oct 11, 2024
Comment on lines +34 to +39
* Patches the `network.operator` CR to set the migration mode to `Live` for OpenShiftSDN and deploys the OpenShiftSDN network plugin in migration mode.
* Deploys OVN-Kubernetes with hybrid overlay enabled.
* Waits for both CNI plugins to be deployed and updates the conditions in the status of the `network.config` CR.
* Triggers the MCO to apply the new machine config to each machine config pool, which includes node cordoning, draining, and rebooting.
* Removes migration-related fields from the `network.operator` CR and performs cleanup actions, such as deleting OpenShift SDN resources and redeploying OVN-Kubernetes in normal mode with the necessary configurations.
* Waits for the OpenShiftSDN redeployment and updates the status conditions in the `network.config` CR to indicate migration completion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark these up? Or switch to "OpenShift SDN" if a general reference?

Suggested change
* Patches the `network.operator` CR to set the migration mode to `Live` for OpenShiftSDN and deploys the OpenShiftSDN network plugin in migration mode.
* Deploys OVN-Kubernetes with hybrid overlay enabled.
* Waits for both CNI plugins to be deployed and updates the conditions in the status of the `network.config` CR.
* Triggers the MCO to apply the new machine config to each machine config pool, which includes node cordoning, draining, and rebooting.
* Removes migration-related fields from the `network.operator` CR and performs cleanup actions, such as deleting OpenShift SDN resources and redeploying OVN-Kubernetes in normal mode with the necessary configurations.
* Waits for the OpenShiftSDN redeployment and updates the status conditions in the `network.config` CR to indicate migration completion.
* Patches the `network.operator` CR to set the migration mode to `Live` for `OpenShiftSDN` and deploys the `OpenShiftSDN` network plugin in migration mode.
* Deploys OVN-Kubernetes with hybrid overlay enabled.
* Waits for both CNI plugins to be deployed and updates the conditions in the status of the `network.config` CR.
* Triggers the MCO to apply the new machine config to each machine config pool, which includes node cordoning, draining, and rebooting.
* Removes migration-related fields from the `network.operator` CR and performs cleanup actions, such as deleting OpenShift SDN resources and redeploying OVN-Kubernetes in normal mode with the necessary configurations.
* Waits for the `OpenShiftSDN` redeployment and updates the status conditions in the `network.config` CR to indicate migration completion.

Comment on lines +47 to +52
Cluster:: As nodes reboot, the cluster assigns IP addresses to pods on the OpenShift-SDN network.

|
Enable the MCO after all nodes in the cluster reboot.
|
MCO:: Rolls out an update to the systemd configuration necessary for OpenShift SDN; the MCO updates a single machine per pool at a time by default, so the total time the migration takes increases with the size of the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see "OpenShift-SDN" and "OpenShift SDN":

Suggested change
Cluster:: As nodes reboot, the cluster assigns IP addresses to pods on the OpenShift-SDN network.
|
Enable the MCO after all nodes in the cluster reboot.
|
MCO:: Rolls out an update to the systemd configuration necessary for OpenShift SDN; the MCO updates a single machine per pool at a time by default, so the total time the migration takes increases with the size of the cluster.
Cluster:: As nodes reboot, the cluster assigns IP addresses to pods on the OpenShift SDN network.
|
Enable the MCO after all nodes in the cluster reboot.
|
MCO:: Rolls out an update to the systemd configuration necessary for OpenShift SDN; the MCO updates a single machine per pool at a time by default, so the total time the migration takes increases with the size of the cluster.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 11, 2024
@adellape adellape added this to the Continuous Release milestone Oct 11, 2024
@stevsmit stevsmit merged commit ae289a2 into openshift:enterprise-4.15 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants