Skip to content

Bug#1512813 - added notes for NO_PROXY variable for scaleup playbook#7719

Merged
gaurav-nelson merged 1 commit intoopenshift:masterfrom
gaurav-nelson:bug1512813-fixes
Feb 14, 2018
Merged

Bug#1512813 - added notes for NO_PROXY variable for scaleup playbook#7719
gaurav-nelson merged 1 commit intoopenshift:masterfrom
gaurav-nelson:bug1512813-fixes

Conversation

@gaurav-nelson
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2018
@gaurav-nelson
Copy link
Contributor Author

@nekop Can you please check this one?

@nekop
Copy link
Contributor

nekop commented Feb 13, 2018

@gaurav-nelson LGTM

@gaurav-nelson
Copy link
Contributor Author

@openshift/team-documentation PTAL

@gaurav-nelson gaurav-nelson added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 13, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaleup playbook

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it is recommended to use a/use a

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 13, 2018
@ahardin-rh
Copy link
Contributor

@gaurav-nelson Just small nits from me. Otherwise, looks good!

@gaurav-nelson
Copy link
Contributor Author

Thank you @ahardin-rh
Updated, rebased, and ready to merge.

@gaurav-nelson gaurav-nelson merged commit 6b1f862 into openshift:master Feb 14, 2018
@gaurav-nelson gaurav-nelson deleted the bug1512813-fixes branch February 14, 2018 01:16
@gaurav-nelson
Copy link
Contributor Author

/cherrypick enterprise-3.5-stage

@openshift-cherrypick-robot

@gaurav-nelson: new pull request created: #7783

Details

In response to this:

/cherrypick enterprise-3.5-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Contributor Author

/cherrypick enterprise-3.6-stage
/cherrypick enterprise-3.7-stage
/cherrypick enterprise-3.9-stage

@openshift-cherrypick-robot

@gaurav-nelson: new pull request created: #7784

Details

In response to this:

/cherrypick enterprise-3.6-stage
/cherrypick enterprise-3.7-stage
/cherrypick enterprise-3.9-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Contributor Author

/cherrypick enterprise-3.7-stage

@openshift-cherrypick-robot

@gaurav-nelson: new pull request created: #7785

Details

In response to this:

/cherrypick enterprise-3.7-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Contributor Author

/cherrypick enterprise-3.9-stage

@openshift-cherrypick-robot

@gaurav-nelson: new pull request created: #7786

Details

In response to this:

/cherrypick enterprise-3.9-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson gaurav-nelson added this to the Next Release milestone Feb 14, 2018
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published - 02/16/2018 Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants