Skip to content

Bug#1452816 - fixes - Added required roles and permissions for all cloudproviders#7797

Merged
gaurav-nelson merged 1 commit into
openshift:masterfrom
gaurav-nelson:bug1452816-fixes
Mar 1, 2018
Merged

Bug#1452816 - fixes - Added required roles and permissions for all cloudproviders#7797
gaurav-nelson merged 1 commit into
openshift:masterfrom
gaurav-nelson:bug1452816-fixes

Conversation

@gaurav-nelson
Copy link
Copy Markdown
Contributor

@tomassedovic
Copy link
Copy Markdown

The OpenStack part looks good to me.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2018
@gaurav-nelson gaurav-nelson added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 27, 2018
@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

gaurav-nelson commented Feb 27, 2018

@openshift/team-documentation PTAL ⛈ 🌩 🌧 🌨

Comment thread install_config/configuring_aws.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the intro sentence but rework it to say:
Configuring AWS for {product-title} requires the following permissions.

Then, instead of using a bullet point to label the tables, I would use:

. Master Permissions

and

.Node Permissions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think you mean .Master Permissions (table heading) and not . Master Permissions (numbered list)

Comment thread install_config/configuring_aws.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Load Balancer/load balancer

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 28, 2018
@gaurav-nelson gaurav-nelson merged commit a3e3b7a into openshift:master Mar 1, 2018
@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-3.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gaurav-nelson: new pull request created: #7977

Details

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-3.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gaurav-nelson: new pull request created: #7978

Details

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-3.6

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gaurav-nelson: new pull request created: #7979

Details

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-3.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gaurav-nelson: #7797 failed to apply on top of branch "enterprise-3.5":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install_config/configuring_aws.adoc
M	install_config/configuring_azure.adoc
M	install_config/configuring_gce.adoc
M	install_config/configuring_openstack.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/configuring_openstack.adoc
Auto-merging install_config/configuring_gce.adoc
Auto-merging install_config/configuring_azure.adoc
Auto-merging install_config/configuring_aws.adoc
CONFLICT (content): Merge conflict in install_config/configuring_aws.adoc
Patch failed at 0001 Added required roles and permissions for all cloudproviders.

Details

In response to this:

/cherrypick enterprise-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants