-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ROX-19799: Update docs for VM2.0 #78059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-19799: Update docs for VM2.0 #78059
Conversation
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
abd3e22 to
34d802c
Compare
9cf26f3 to
a7e1342
Compare
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Vulnerability Management -> Dashboard is deprecated, do you think that all the places that tell user to go the dashboard should also mention that it is deprecated and that the similar outcome can be achieved using Workload CVEs, Node CVE and Platform CVEs ?
Also, I do not see docs for Node CVEs, Platform CVEs and Exception Management. Would those be added in a separate branch?
Edit : I missed the note in the PR about focusing on just workload CVEs part
a7e1342 to
e107673
Compare
1a89fea to
ef58325
Compare
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
fde534e to
6883456
Compare
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dvail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this Kerry - it looks great! A handful of minor corrections from me but otherwise gtg. 🚢
modules/identify-deployments-with-most-severe-policy-violations.adoc
Outdated
Show resolved
Hide resolved
f1e6de2 to
9d99262
Compare
|
/label peer-review-in-progress |
9d99262 to
57c831e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions for your consideration; overall lgtm!
modules/find-clusters-with-most-kubernetes-and-istio-vulnerabilities.adoc
Outdated
Show resolved
Hide resolved
modules/find-clusters-with-most-kubernetes-and-istio-vulnerabilities.adoc
Outdated
Show resolved
Hide resolved
operating/manage-vulnerabilities/vulnerability-management-dashboard.adoc
Outdated
Show resolved
Hide resolved
operating/manage-vulnerabilities/vulnerability-management-dashboard.adoc
Outdated
Show resolved
Hide resolved
|
/remove-label peer-review-in-progress |
57c831e to
746294b
Compare
kcarmichael08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Agil for the feedback - it really helped the doc improve, I think!
operating/manage-vulnerabilities/vulnerability-management-dashboard.adoc
Outdated
Show resolved
Hide resolved
746294b to
262af44
Compare
|
@kcarmichael08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick rhacs-docs-4.5 |
|
@kcarmichael08: new pull request created: #79410 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.5+
Issue
Links to docs previews:
Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:
Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only
QE review: ACS has no QE, reviewed/approved by SMEs
Additional information:
Note to reviewers (Final draft, July 2024):
Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.
Old notes to reviewers (first draft, June 2024):