Skip to content

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 25, 2024

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review: ACS has no QE, reviewed/approved by SMEs

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 25, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 25, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html
78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19799-vm20 branch 5 times, most recently from 9cf26f3 to a7e1342 Compare July 4, 2024 18:58
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 6, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html
https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html#scan-inactive-images_examine-images-for-vulnerabilities

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 6, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html
https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html#scan-inactive-images_examine-images-for-vulnerabilities

QE review:

  • QE has approved this change.

Additional information:

Note to reviewers:

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.

  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@charmik-redhat charmik-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Vulnerability Management -> Dashboard is deprecated, do you think that all the places that tell user to go the dashboard should also mention that it is deprecated and that the similar outcome can be achieved using Workload CVEs, Node CVE and Platform CVEs ?

Also, I do not see docs for Node CVEs, Platform CVEs and Exception Management. Would those be added in a separate branch?

Edit : I missed the note in the PR about focusing on just workload CVEs part

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2024
@kcarmichael08 kcarmichael08 force-pushed the ROX-19799-vm20 branch 8 times, most recently from 1a89fea to ef58325 Compare July 18, 2024 19:57
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html
https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html#scan-inactive-images_examine-images-for-vulnerabilities

QE review:

  • QE has approved this change.

Additional information:

Note to reviewers:

Final draft (July 2024)

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

First draft (June 2024)

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.

  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html
https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html#scan-inactive-images_examine-images-for-vulnerabilities

QE review:

  • QE has approved this change.

Additional information:

Note to reviewers:

  • Final draft (July 2024): Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

  • Old notes to reviewers (first draft, June 2024):*

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.

  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management.html
https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html#scan-inactive-images_examine-images-for-vulnerabilities

QE review:

  • QE has approved this change.

Additional information:

Note to reviewers:

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review:

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review: ACS has no QE, reviewed/approved by SMEs

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review: ACS has no QE, reviewed/approved by SMEs

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review: ACS has no QE, reviewed/approved by SMEs

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

@kcarmichael08: This pull request references ROX-19799 which is a valid jira issue.

In response to this:

Version(s):
4.5+

Issue

Links to docs previews:

Managing vulnerabilities - Reorganized top-level page and pages underneath for VM:

Examining images for vulnerabilities - updated VM link only
Creating and using deployment collections - updated VM reporting link only

QE review: ACS has no QE, reviewed/approved by SMEs

  • QE has approved this change.

Additional information:

Note to reviewers (Final draft, July 2024):

Updating the instructions for the Dashboard tasks (https://78059--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/vulnerability-management-dashboard) is beyond the scope of this PR. Please do not focus on this section and only mark inaccuracies. This functionality will be deprecated soon.

Old notes to reviewers (first draft, June 2024):

  • There is still some reorganization needed with the "common tasks" section. These are all Dashboard-based instructions, while some of the Workload CVEs equivalents are provided in the "Vulnerability Management" section. Some of the equivalents in the Workload CVEs page need to be added. For now, please focus on reviewing the Workload CVEs information for accuracy, as this information is new or updated following the GUI changes.
  • Need some help documenting the deferral approvals workflow since I don't think the staging environment is capturing my tests with request to defer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@dvail dvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this Kerry - it looks great! A handful of minor corrections from me but otherwise gtg. 🚢

@kcarmichael08 kcarmichael08 force-pushed the ROX-19799-vm20 branch 4 times, most recently from f1e6de2 to 9d99262 Compare July 19, 2024 18:07
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 22, 2024
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for your consideration; overall lgtm!

@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 23, 2024
Copy link
Contributor Author

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Agil for the feedback - it really helped the doc improve, I think!

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2024

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit eca57e2 into openshift:rhacs-docs-main Jul 24, 2024
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #79410

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR rhacs-docs-4.5 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants