Skip to content

[rhacs] add missed peer review comments for VM PR #79492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

[rhacs] add missed peer review comments for VM PR #79492

merged 1 commit into from
Jul 25, 2024

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jul 25, 2024 •
edited
Loading

see #78059

4.5+

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 25, 2024 •
edited
Loading

🤖 Thu Jul 25 18:21:42 - Prow CI generated the docs preview:

https://79492--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/common-vuln-management-tasks.html
https://79492--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scan-rhcos-node-host.html

@kcarmichael08 kcarmichael08 force-pushed the 78059-peer-review-missed-comments branch from 969743d to 4f7e926 Compare July 25, 2024 16:58
@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 25, 2024
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 25, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Jul 25, 2024
stevsmit
stevsmit reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Most question.

operating/manage-vulnerabilities/common-vuln-management-tasks.adoc Outdated
[NOTE]
====
Snoozing node and platform CVEs requires enabling the ROX_VULN_MGMT_LEGACY_SNOOZE environment variable.
Snoozing node and platform CVEs requires that the ROX_VULN_MGMT_LEGACY_SNOOZE environment variable is enabled.
Copy link
Member

@stevsmit stevsmit Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks for ROX_VULN_MGMT_LEGACY_SNOOZE, since it's a variable?

Copy link
Contributor Author

@kcarmichael08 kcarmichael08 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch, thanks!

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 25, 2024
@kcarmichael08 kcarmichael08 force-pushed the 78059-peer-review-missed-comments branch from 4f7e926 to c735ab2 Compare July 25, 2024 18:11
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2024

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 7f53441 into openshift:rhacs-docs-main Jul 25, 2024
@kcarmichael08 kcarmichael08 deleted the 78059-peer-review-missed-comments branch July 25, 2024 18:35
@kcarmichael08
Copy link
Contributor Author

kcarmichael08 commented Jul 25, 2024

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 25, 2024

@kcarmichael08: new pull request created: #79505

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevsmit stevsmit stevsmit left review comments

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@kcarmichael08 @ocpdocs-previewbot @openshift-cherrypick-robot @stevsmit