Skip to content

OCPBUGS-42088: updates RNs for Egress IPs additional nwts #81968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeAldinger merged 1 commit into from
Sep 19, 2024
Merged

OCPBUGS-42088: updates RNs for Egress IPs additional nwts #81968

JoeAldinger merged 1 commit into from
Sep 19, 2024

Conversation

@JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Sep 17, 2024 •
edited
Loading

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-42088

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
4.15 PR
4.16 PR

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2024

@JoeAldinger: This pull request references Jira Issue OCPBUGS-42088, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42088 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-42088

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
4.15 PR
4.16 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2024
This was referenced Sep 17, 2024
Merged
Merged
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Sep 17, 2024

LGTM

1 similar comment
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Sep 17, 2024

LGTM

@anuragthehatter
Copy link

anuragthehatter commented Sep 17, 2024

cc @jechen0648 as @huiran0826 is on PTO

@palonsoro
Copy link
Contributor

palonsoro commented Sep 17, 2024

LGTM

@JoeAldinger
Copy link
Contributor Author

JoeAldinger commented Sep 17, 2024

/retest

@JoeAldinger JoeAldinger added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 17, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Sep 17, 2024
@jechen0648
Copy link

jechen0648 commented Sep 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2024

@JoeAldinger: This pull request references Jira Issue OCPBUGS-42088, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42088 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-42088

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
4.15 PR
4.16 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 17, 2024

🤖 Tue Sep 17 18:20:15 - Prow CI generated the docs preview:

https://81968--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2024

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jldohmann
jldohmann approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. do we have a consensus on how to mark things as being generally available? i see it sometimes as "Generally Available", which is in line with how we denote things as "Technology Preview", but i see it more commonly as "generally available". either way, this is outside the scope of this PR 😄

@jldohmann jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 17, 2024
@palonsoro
Copy link
Contributor

palonsoro commented Sep 18, 2024

@jldohmann my two cents on your doubt: "Generally Available" is often abbreviated GA the same way "Technology Preview" is often abbreviated TP, so I guess keeping the capital letters makes sense when we talk about the feature supportability status. But as you said, this is beyond the scope of the PR.

@CFields651
Copy link

CFields651 commented Sep 19, 2024

LGTM

@JoeAldinger JoeAldinger merged commit e96de7b into openshift:enterprise-4.14 Sep 19, 2024
@JoeAldinger JoeAldinger deleted the OCPBUGS-42088 branch September 19, 2024 22:16
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@JoeAldinger: Jira Issue OCPBUGS-42088 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-42088

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
4.15 PR
4.16 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jldohmann jldohmann jldohmann approved these changes

+1 more reviewer

@palonsoro palonsoro palonsoro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jechen0648 jechen0648

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

10 participants

@JoeAldinger @openshift-ci-robot @kalexand-rh @ahardin-rh @anuragthehatter @palonsoro @jechen0648 @ocpdocs-previewbot @CFields651 @jldohmann