Skip to content

[enterprise-4.16] OCPBUGS-42226: Correcting Instructions to Disable Build Strategy #82193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

[enterprise-4.16] OCPBUGS-42226: Correcting Instructions to Disable Build Strategy #82193

merged 1 commit into from
Sep 19, 2024

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 19, 2024

This is an automated cherry-pick of #82186

/assign adellape

@adambkaplan
Correcting Instructions to Disable Build Strategy
9eb3696 
The documentation for disabling builds by strategy was at one point
updated to include inaccurate instructions [1]. When followed end to
end, these instructions granted the `admin` and `edit` user roles
permission to run builds with the `Source` and `Custom` build
strategies. The latter build strategy is particularly dangerous, as it
grants users permission to execute arbitrary commands in a privileged
container.

This change restores these instructions to the original intent of
verifying that the `admin` and `edit` user roles do not have permission
to create Docker strategy builds. It also simplifies the instruction to
add the `autoupdate=false` RBAC annotation.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1923869

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
1 task
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-42217 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [enterprise-4.16] : Correcting Instructions to Disable Build Strategy

In response to this:

This is an automated cherry-pick of #82186

/assign adellape

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-42217, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42217 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-42217 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [enterprise-4.16] : Correcting Instructions to Disable Build Strategy

In response to this:

This is an automated cherry-pick of #82186

/assign adellape

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [enterprise-4.16] OCPBUGS-42217: Correcting Instructions to Disable Build Strategy [enterprise-4.16] : Correcting Instructions to Disable Build Strategy Sep 19, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #82186

/assign adellape

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2024
@adambkaplan adambkaplan changed the title [enterprise-4.16] : Correcting Instructions to Disable Build Strategy [enterprise-4.16] OCPBUGS-42226: Correcting Instructions to Disable Build Strategy Sep 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42226, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-42225 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #82186

/assign adellape

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adellape adellape merged commit b3b060f into openshift:enterprise-4.16 Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42226: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42226 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #82186

/assign adellape

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adellape adellape

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @adellape @adambkaplan