Skip to content

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Oct 14, 2024

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be yet visible in the documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2024
@eromanova97 eromanova97 force-pushed the OBSDOCS-1408 branch 2 times, most recently from 382a8a7 to 6200fd0 Compare October 14, 2024 13:20
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be yet visible in the documentation.

This issue also asks for changes in ID, however, in the final product, the two procedure will be in a different place, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be yet visible in the documentation.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be yet visible in the documentation.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-1408 branch 2 times, most recently from 7f6df20 to 97a79e7 Compare October 14, 2024 14:23
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be yet visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse insteda of duplication. I will also prevents creation of multiple new modules with basically identical contents.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse insteda of duplication. I will also prevents creation of multiple new modules with basically identical contents.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. I will also prevents creation of multiple new modules with basically identical contents.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. Ii also prevents creation of multiple new modules with basically identical contents.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-1408 branch 2 times, most recently from cb14a92 to 4b77126 Compare October 15, 2024 18:39
@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 18, 2024
@juzhao
Copy link

juzhao commented Oct 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 21, 2024
@kcarmichael08 kcarmichael08 removed the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 21, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some confusion about the tagging - can you confirm what I've assumed in my second comment is the way that it is supposed to display? Also, I wasn't sure if "wildcards aren't supported" means that you cannot use asterisks. I am not sure how to check a preview of what goes through PV1.

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 21, 2024
@skrthomas
Copy link
Contributor

I am not sure how to check a preview of what goes through PV1.

Unfortunately the only way to check this now is to just go check docs.rehat.com after merging and make sure it all looks as expected. Tags are one of those things you have to doublecheck. They've been known to work well in simple form, but more complicated tags can throw PV1 for a loop. Just bc of limited testing in ocp docs, we don't have a ton of data. So its up to writers who use them to double check and make sure the rendering is OK.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2024

@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue.

In response to this:

Version(s): no CP

Issue: OBSDOCS-1408

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 22, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@eromanova97
Copy link
Contributor Author

eromanova97 commented Oct 22, 2024

Hello @kcarmichael08 @skrthomas thank you for your feedback! I added some explanatory comments in the assemby and module to make it easier for reviewing, I hope that helps 🙂 If you have any tips how to make it even easier for the reviewers (because more such PRs will be coming) , please let me know 🙏 Thanks!

Edit: I am also trying to investigate the possibility to test this for docs.redhat before merging (openshift docs work as expected), because it would be a big issue to fix only after it gets merged. I will update on this as soon as I have more information.

Copy link

openshift-ci bot commented Oct 22, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 22, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 22, 2024
@skrthomas skrthomas merged commit 7187840 into openshift:monitoring-docs-restructure Oct 22, 2024
2 checks passed
@eromanova97 eromanova97 deleted the OBSDOCS-1408 branch October 23, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants