-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1408: Make an example separation for Moving monitoring compon… #83431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1408: Make an example separation for Moving monitoring compon… #83431
Conversation
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
382a8a7
to
6200fd0
Compare
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6200fd0
to
38c30a3
Compare
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7f6df20
to
97a79e7
Compare
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cb14a92
to
4b77126
Compare
modules/monitoring-moving-monitoring-components-to-different-nodes.adoc
Outdated
Show resolved
Hide resolved
4b77126
to
9a360b3
Compare
/label peer-review-needed |
/lgtm |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some confusion about the tagging - can you confirm what I've assumed in my second comment is the way that it is supposed to display? Also, I wasn't sure if "wildcards aren't supported" means that you cannot use asterisks. I am not sure how to check a preview of what goes through PV1.
Unfortunately the only way to check this now is to just go check docs.rehat.com after merging and make sure it all looks as expected. Tags are one of those things you have to doublecheck. They've been known to work well in simple form, but more complicated tags can throw PV1 for a loop. Just bc of limited testing in ocp docs, we don't have a ton of data. So its up to writers who use them to double check and make sure the rendering is OK. |
@eromanova97: This pull request references OBSDOCS-1408 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…ents to different nodes section
9a360b3
to
967fc24
Compare
New changes are detected. LGTM label has been removed. |
Hello @kcarmichael08 @skrthomas thank you for your feedback! I added some explanatory comments in the assemby and module to make it easier for reviewing, I hope that helps 🙂 If you have any tips how to make it even easier for the reviewers (because more such PRs will be coming) , please let me know 🙏 Thanks! Edit: I am also trying to investigate the possibility to test this for docs.redhat before merging (openshift docs work as expected), because it would be a big issue to fix only after it gets merged. I will update on this as soon as I have more information. |
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
7187840
into
openshift:monitoring-docs-restructure
Version(s): no CP
Issue: OBSDOCS-1408
Link to docs preview:
OCP:
ROSA/OSD: https://83431--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/configuring-the-monitoring-stack.html#moving-monitoring-components-to-different-nodes-uwm_configuring-the-monitoring-stack
QE review:
Additional information:
This is the first example split of core platform monitoring and user workload monitoring procedures. The issue is getting merged to only
monitoring-docs-restructure
, not tomain
, therefore this change will not be visible in the documentation.The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.
This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)