Skip to content

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Oct 22, 2024

Version(s): No version for CP

Issue: OBSDOCS-1433

Link to docs preview:
Configuring a persistent volume claim for core platform monitoring
Configuring a persistent volume claim for monitoring of user-defined projects
Resizing a persistent volume for core platform monitoring
Resizing a persistent volume for monitoring of user-defined projects
Modifying the retention time and size for Prometheus metrics data for core platform monitoring
Modifying the retention time and size for Prometheus metrics data for user-defined monitoring

QE review:

  • QE has approved this change.

Additional information:
This is the part 2 split of core platform monitoring (CPM) and user workload monitoring (UWM) procedures. The issue is getting merged to only monitoring-docs-restructure, not to main, therefore this change will not be visible in the documentation.

The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.

This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)

You can see #83431 for reference.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2024
@eromanova97 eromanova97 force-pushed the OBSDOCS-1433 branch 4 times, most recently from 1e0511f to 4c1e0d0 Compare October 23, 2024 08:09
@juzhao
Copy link

juzhao commented Oct 24, 2024

https://83910--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-the-monitoring-stack.html#modifying-retention-time-and-size-for-prometheus-metrics-data-uwm_configuring-the-monitoring-stack
retention time and size configuration for UWM prometheus example is wrong

metadata:
  name: cluster-monitoring-config
  namespace: openshift-monitoring

should be

metadata:
  name: user-workload-monitoring-config
  namespace: openshift-user-workload-monitoring

@juzhao
Copy link

juzhao commented Oct 24, 2024

Modifying the retention time and size for Prometheus metrics data for core platform monitoring
and
Modifying the retention time and size for Prometheus metrics data for user-defined monitoring

they have the same explanation and NOTE before each Prerequisites
I think one is fine, otherwise it's too redundant

@eromanova97
Copy link
Contributor Author

Modifying the retention time and size for Prometheus metrics data for core platform monitoring and Modifying the retention time and size for Prometheus metrics data for user-defined monitoring

they have the same explanation and NOTE before each Prerequisites I think one is fine, otherwise it's too redundant

Hello @juzhao yes, thank you for the comment. I added this line in the module:
// The following section will be removed and made into its separate concept module.

because I think that part should be in its separate module anyway. So it will be removed in another PR from the procedure and made into its own conceptual module, therefore removing the duplication. I apologise it is hard to estimate what should I do in one PR, because I do not want to make all of the review jobs too difficult, so I am trying to just concentrate on one topic per PR (these changes are huge 😅 )

And the users will not see these changes anyway until it is all ready 😁
I created a JIRA to track this change: https://issues.redhat.com/browse/OBSDOCS-1464 to not forget about this. Thank you for your thoughtful reviews! 🙂

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 29, 2024
@juzhao
Copy link

juzhao commented Oct 29, 2024

LGTM, waiting for others to review

@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 29, 2024
@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 30, 2024
Copy link

openshift-ci bot commented Oct 30, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 30, 2024
@mburke5678 mburke5678 merged commit a2c0af8 into openshift:monitoring-docs-restructure Oct 30, 2024
2 checks passed
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 30, 2024
@eromanova97 eromanova97 deleted the OBSDOCS-1433 branch October 31, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants