-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Separate UWM and core platform monitoring (part 2) #83910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate UWM and core platform monitoring (part 2) #83910
Conversation
1e0511f
to
4c1e0d0
Compare
https://83910--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-the-monitoring-stack.html#modifying-retention-time-and-size-for-prometheus-metrics-data-uwm_configuring-the-monitoring-stack
should be
|
4c1e0d0
to
c896355
Compare
Modifying the retention time and size for Prometheus metrics data for core platform monitoring they have the same explanation and NOTE before each |
Hello @juzhao yes, thank you for the comment. I added this line in the module: because I think that part should be in its separate module anyway. So it will be removed in another PR from the procedure and made into its own conceptual module, therefore removing the duplication. I apologise it is hard to estimate what should I do in one PR, because I do not want to make all of the review jobs too difficult, so I am trying to just concentrate on one topic per PR (these changes are huge 😅 ) And the users will not see these changes anyway until it is all ready 😁 |
/label peer-review-needed |
LGTM, waiting for others to review |
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
c896355
to
5b21936
Compare
5b21936
to
b3adac8
Compare
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
a2c0af8
into
openshift:monitoring-docs-restructure
Version(s): No version for CP
Issue: OBSDOCS-1433
Link to docs preview:
Configuring a persistent volume claim for core platform monitoring
Configuring a persistent volume claim for monitoring of user-defined projects
Resizing a persistent volume for core platform monitoring
Resizing a persistent volume for monitoring of user-defined projects
Modifying the retention time and size for Prometheus metrics data for core platform monitoring
Modifying the retention time and size for Prometheus metrics data for user-defined monitoring
QE review:
Additional information:
This is the part 2 split of core platform monitoring (CPM) and user workload monitoring (UWM) procedures. The issue is getting merged to only
monitoring-docs-restructure
, not tomain
, therefore this change will not be visible in the documentation.The tagging is implemented so that once this is moved to two different assemblies, we will still only have one module to maintain. This will ensure content reuse instead of duplication. It also prevents creation of multiple new modules with basically identical content.
This issue also asks for changes in ID, however, in the final product, the two procedures will be in a different assembly, therefore two IDs will not be needed (context parameter will take care of it)
You can see #83431 for reference.