Skip to content

Conversation

@stevsmit
Copy link
Member

@stevsmit stevsmit commented Oct 16, 2024

PR is a size medium because it copies the 4.16 module from https://raw.githubusercontent.com/openshift/openshift-docs/refs/heads/enterprise-4.16/modules/nw-ovn-kubernetes-live-migration-about.adoc. The 4.16 module had changes in it that were missed during the manual cherry pick from #81120. This is a whole confusing thing, so PM me if you have questions.

This PR only adds the following line, as far as net new content goes:

For {product-title} version 4.15, it is available for versions 4.15.31 and later.

The rest of the changes were already peer reviewed several times. It's just pulling that content from 4.16 into 4.15.

Version(s):
4.15

Issue:
#83666

Link to docs preview:
https://83666--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html#nw-ovn-kubernetes-live-migration-about_migrate-from-openshift-sdn

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Oct 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2024

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 17, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 17, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 17, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2024

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 98d063a into openshift:enterprise-4.15 Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants