Adds live migration procedures for sdn to ovnk #81120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
from
5a57ace to
7c55bfc
Compare
openshift-ci
bot
added
size/XL
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
2 times, most recently
from
c827292 to
12d3525
Compare
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
2 times, most recently
from
4412a4c to
6935ac5
Compare
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
4 times, most recently
from
959d428 to
576cda2
Compare
openshift-ci
bot
added
size/XXL
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
from
576cda2 to
cf80199
Compare
openshift-merge-robot
added
the
needs-rebase
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
from
cf80199 to
d3712ef
Compare
openshift-merge-robot
removed
the
needs-rebase
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
from
d3712ef to
2322b2b
Compare
|
/lgtm |
Contributor
|
LGTM |
stevsmit
added
the
peer-review-needed
Updates limited live migration procedure to find various resources Multicast enabled namespaces change Further changes
stevsmit
force-pushed
the
11834-live-migration-proc-backport
branch
from
2322b2b to
f7900ce
Compare
|
New changes are detected. LGTM label has been removed. |
|
@stevsmit: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
adellape
added
the
peer-review-in-progress
adellape
reviewed
Oct 11, 2024
| .Procedure | ||
|
|
||
| . As an {product-title} cluster administrator, check for egress firewall resources. You can do this by using the `oc` CLI, or by using the {product-title} web console. |
Contributor
There was a problem hiding this comment.
Colon leading into substeps, per ISG.
Suggested change
| . As an {product-title} cluster administrator, check for egress firewall resources. You can do this by using the `oc` CLI, or by using the {product-title} web console. | |
| . As an {product-title} cluster administrator, check for egress firewall resources. You can do this by using the `oc` CLI, or by using the {product-title} web console: |
|
|
||
| . As an {product-title} cluster administrator, check for egress firewall resources. You can do this by using the `oc` CLI, or by using the {product-title} web console. | ||
|
|
||
| .. To check for egress firewall resource by using the `oc` CLI tool: |
Contributor
There was a problem hiding this comment.
This and line 65 could be unordered, no? Since you choose either one (or both)?
Suggested change
| .. To check for egress firewall resource by using the `oc` CLI tool: | |
| * To check for egress firewall resource by using the `oc` CLI tool: |
| + | ||
| Ensure that the behavior of this resource is intended because it could have changed after migration. For more information about egress firewalls, see "Configuring an egress firewall for a project". | ||
|
|
||
| .. To check for egress firewall resources by using the {product-title} web console: |
Contributor
There was a problem hiding this comment.
Suggested change
| .. To check for egress firewall resources by using the {product-title} web console: | |
| * To check for egress firewall resources by using the {product-title} web console: |
Comment on lines
+71
to
+73
| . Check your cluster for egress IP resources. You can do this by using the `oc` CLI, or by using the {product-title} web console. | ||
|
|
||
| .. To check for egress IPs by using the `oc` CLI tool: |
Contributor
There was a problem hiding this comment.
Same:
Suggested change
| . Check your cluster for egress IP resources. You can do this by using the `oc` CLI, or by using the {product-title} web console. | |
| .. To check for egress IPs by using the `oc` CLI tool: | |
| . Check your cluster for egress IP resources. You can do this by using the `oc` CLI, or by using the {product-title} web console: | |
| * To check for egress IPs by using the `oc` CLI tool: |
| + | ||
| Repeat this for all egress IPs. Ensure that the behavior of each resource is intended because it could have changed after migration. For more information about EgressIPs, see "Configuring an EgressIP address". | ||
|
|
||
| .. To check for egress IPs by using the {product-title} web console: |
Contributor
There was a problem hiding this comment.
Suggested change
| .. To check for egress IPs by using the {product-title} web console: | |
| * To check for egress IPs by using the {product-title} web console: |
Comment on lines
+11
to
+12
| * `100.64.0.0/16`. This IP address range is used for the `internalJoinSubnet` parameter of OVN-Kubernetes by default. | ||
| * `100.88.0.0/16`. This IP address range is used for the `internalTransSwitchSubnet` parameter of OVN-Kubernetes by default. |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| * `100.64.0.0/16`. This IP address range is used for the `internalJoinSubnet` parameter of OVN-Kubernetes by default. | |
| * `100.88.0.0/16`. This IP address range is used for the `internalTransSwitchSubnet` parameter of OVN-Kubernetes by default. | |
| * `100.64.0.0/16`: This IP address range is used for the `internalJoinSubnet` parameter of OVN-Kubernetes by default. | |
| * `100.88.0.0/16`: This IP address range is used for the `internalTransSwitchSubnet` parameter of OVN-Kubernetes by default. |
|
|
||
| [NOTE] | ||
| ==== | ||
| This is an optional procedure and must only be used if the migration was blocked after using the `oc patch Network.config.openshift.io cluster --type='merge' --patch '{"metadata":{"annotations":{"network.openshift.io/network-type-migration":""}},"spec":{"networkType":"OVNKubernetes"}}'` command "Initiating the limited live migration process". |
Contributor
There was a problem hiding this comment.
Is there maybe a missing "from" before the section title reference? Also suggest moving the long command to its own block.
Suggested change
| This is an optional procedure and must only be used if the migration was blocked after using the `oc patch Network.config.openshift.io cluster --type='merge' --patch '{"metadata":{"annotations":{"network.openshift.io/network-type-migration":""}},"spec":{"networkType":"OVNKubernetes"}}'` command "Initiating the limited live migration process". | |
| This is an optional procedure and must only be used if the migration was blocked after using the following command from "Initiating the limited live migration process": | |
| [source,terminal] | |
| ---- | |
| $ oc patch Network.config.openshift.io cluster --type='merge' \ | |
| --patch '{"metadata":{"annotations":{"network.openshift.io/network-type-migration":""}},"spec":{"networkType":"OVNKubernetes"}}'` | |
| ---- |
| .Procedure | ||
|
|
||
| . If the `100.64.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.63.0.0/16`. |
Contributor
There was a problem hiding this comment.
White space and colon:
Suggested change
| . If the `100.64.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.63.0.0/16`. | |
| . If the `100.64.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.63.0.0/16`. |
| $ oc patch network.operator.openshift.io cluster --type='merge' -p='{"spec":{"defaultNetwork":{"ovnKubernetesConfig":{"ipv4":{"internalJoinSubnet": "100.63.0.0/16"}}}}}' | ||
| ---- | ||
|
|
||
| . If the `100.88.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.99.0.0/16`. |
Contributor
There was a problem hiding this comment.
Suggested change
| . If the `100.88.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.99.0.0/16`. | |
| . If the `100.88.0.0/16` IP address range is already in use, enter the following command to patch it to a different range. The following example uses `100.99.0.0/16`: |
| It is not possible to upgrade a cluster to {product-title} 4.17 if it is using the OpenShift SDN network plugin. You must migrate to the OVN-Kubernetes plugin before upgrading to {product-title} 4.17. | ||
| ==== | ||
|
|
||
| To learn more about OVN-Kubernetes, read xref:../../networking/ovn_kubernetes_network_provider/about-ovn-kubernetes#about-ovn-kubernetes[About the OVN-Kubernetes network plugin]. |
Contributor
There was a problem hiding this comment.
Suggested change
| To learn more about OVN-Kubernetes, read xref:../../networking/ovn_kubernetes_network_provider/about-ovn-kubernetes#about-ovn-kubernetes[About the OVN-Kubernetes network plugin]. | |
| To learn more about OVN-Kubernetes, see xref:../../networking/ovn_kubernetes_network_provider/about-ovn-kubernetes#about-ovn-kubernetes[About the OVN-Kubernetes network plugin]. |
adellape
added
peer-review-done
Member
Author
|
@adellape I'll need to make these changes in 4.16 and CP back to 4.15 with a new PR |
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry pick of both f328ff3 and 0d14457. This content of this PR does not exactly match its cherry picks. The content of this PR does match the content that currently exists in OCP docs version 4.16, as it should. I used these original PRs as a base and then copied the content from each module from version 4.16.
For review: I suggest comparing this PR to the modules in 4.16. Changes suggested to this PR would need to be done in 4.16 and then cherry-picked back to 4.15, because the content must match.
tl;dr: it is a direct copy of content that exists in version 4.16.
Preview: https://81120--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html
Version(s):
4.15
Issue:
Jira: https://issues.redhat.com/browse/OSDOCS-11834
Link to docs preview:
QE review: