[OSDOCS-12093]: Adding HCP content to 4.17 Welcome #84101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
|
🤖 Wed Nov 06 22:00:20 - Prow CI generated the docs preview: |
lahinson
force-pushed
the
osdocs-12093-hcp-welcome
branch
from
eb7243d to
53b3920
Compare
openshift-ci
bot
added
size/M
Contributor
Author
|
@xenolinux - When you're back from PTO next week, PTAL at the Welcome page and let me know if you think I should highlight different topics or any additional topics. Thank you! |
xenolinux
approved these changes
Oct 28, 2024
Contributor
xenolinux
left a comment
xenolinux
left a comment
There was a problem hiding this comment.
Thanks for the welcome page PR.
The table looks great!
|
/lgtm |
lahinson
added
the
peer-review-needed
mburke5678
added
the
peer-review-in-progress
mburke5678
reviewed
Oct 28, 2024
Contributor
|
@lahinson Just one comment. Otherwise LGTM |
mburke5678
added
peer-review-done
lahinson
force-pushed
the
osdocs-12093-hcp-welcome
branch
from
53b3920 to
af68373
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
lahinson
force-pushed
the
osdocs-12093-hcp-welcome
branch
from
af68373 to
0694566
Compare
lahinson
force-pushed
the
osdocs-12093-hcp-welcome
branch
from
0694566 to
a3a8d0e
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.17 only
Issue: https://issues.redhat.com/browse/OSDOCS-12093
Link to docs preview: https://84101--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/learn_more_about_openshift.html#self-managed-hcp
QE review:
Additional information: Do not merge until the MCE 2.7 release on Nov. 5.