Skip to content

Lists what hostnames and IPs are needed for custom certificates #8544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2018
Merged

Lists what hostnames and IPs are needed for custom certificates #8544

merged 3 commits into from
Apr 12, 2018

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Apr 2, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2018
@mburke5678 mburke5678 changed the title Including info on adding CN to SAN list Lists what hostnames and IPs are needed for custom certificates Apr 2, 2018
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 9, 2018

@rjhowe PTAL

rjhowe
rjhowe reviewed Apr 9, 2018
View reviewed changes
install_config/registry/deploy_registry_existing_clusters.adoc Outdated
Copy link

@rjhowe rjhowe Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "If using Subject Alternative Names (SAN)".

The secured registry should contain the following in the SAN list

zhaozhanqi
zhaozhanqi reviewed Apr 10, 2018
View reviewed changes
install_config/registry/deploy_registry_existing_clusters.adoc Outdated
Copy link

@zhaozhanqi zhaozhanqi Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nostnames/hostnames

@mburke5678 mburke5678 added this to the Next Release milestone Apr 10, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 10, 2018

@zhaozhanqi @rjhowe What OpenShift versions does this affect? The customer case involves 3.4, Should this PR be merged 3.4+?

@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 10, 2018

@openshift/team-documentation PTAL

bfallonf
bfallonf reviewed Apr 10, 2018
View reviewed changes
install_config/registry/deploy_registry_existing_clusters.adoc Outdated
docker-registry.default.svc
----
+
* service IP address. Use the following command to get the Docker registry service IP address:
Copy link

@bfallonf bfallonf Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's examples above, but this isn't showing an example. It's showing how to find what you need to put into the file. Is that correct? If yes, I'd suggest consistency, whether through how to find the example or the example itself. This goes for the below as well.

bfallonf
bfallonf reviewed Apr 10, 2018
View reviewed changes
install_config/registry/deploy_registry_existing_clusters.adoc
----
+
* service IP address. Use the following command to get the Docker registry service IP address:
+
Copy link

@bfallonf bfallonf Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "Service..." above have caps? Goes for the lines below as well, as well.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 11, 2018

@bfallonf @zhaozhanqi @rjhowe PTAL at the changes I made based on Brice's comments.

@bfallonf
Copy link

bfallonf commented Apr 11, 2018

@mburke5678 LGTM

@zhaozhanqi
Copy link

zhaozhanqi commented Apr 12, 2018

LGTM

@mburke5678 mburke5678 merged commit 02843f8 into openshift:master Apr 12, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 12, 2018

/cherrypick enterprise-3.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 12, 2018

@mburke5678: #8544 failed to apply on top of branch "enterprise-3.7":

.git/rebase-apply/patch:20: trailing whitespace.
docker-registry.default.svc 
.git/rebase-apply/patch:35: trailing whitespace.
For example, the server certificate should contain SAN details similar to the following: 
warning: 2 lines add whitespace errors.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install_config/registry/deploy_registry_existing_clusters.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/registry/deploy_registry_existing_clusters.adoc
CONFLICT (content): Merge conflict in install_config/registry/deploy_registry_existing_clusters.adoc
Patch failed at 0001 Including info on adding CN to SAN list

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 12, 2018
Merged
Merged
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 12, 2018

Merged and CP's in #8714

@mburke5678 mburke5678 deleted the BZ-1454482 branch April 12, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@zhaozhanqi zhaozhanqi zhaozhanqi left review comments

@bfallonf bfallonf bfallonf left review comments

@rjhowe rjhowe rjhowe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-3.3 branch/enterprise-3.4 branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 branch/enterprise-3.10 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @bfallonf @zhaozhanqi @openshift-cherrypick-robot @rjhowe @openshift-ci-robot