Skip to content

[RHACS] Fix error in RNs for API deprecation #86947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcarmichael08 merged 1 commit into from
Jan 14, 2025
Merged

[RHACS] Fix error in RNs for API deprecation #86947

kcarmichael08 merged 1 commit into from
Jan 14, 2025

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jan 13, 2025 •
edited
Loading

Version(s):

4.6+

Issue: none, see #86945 and #86944

Link to docs preview: ACS has no QE, approved by SME

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 13, 2025

🤖 Mon Jan 13 16:14:07 - Prow CI generated the docs preview:

https://86947--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes.html

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2025

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vladbologa
vladbologa approved these changes Jan 13, 2025
View reviewed changes
Copy link

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcarmichael08 kcarmichael08 mentioned this pull request Jan 13, 2025
Merged
1 task
@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 rhacs-docs-4.7 peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 13, 2025
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 13, 2025
jeana-redhat
jeana-redhat approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 13, 2025
@kcarmichael08 kcarmichael08 merged commit 99f0232 into openshift:rhacs-docs-main Jan 14, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor Author

kcarmichael08 commented Jan 14, 2025

/cherrypick rhacs-docs-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 14, 2025

@kcarmichael08: new pull request created: #86990

Details

In response to this:

/cherrypick rhacs-docs-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+1 more reviewer

@vladbologa vladbologa vladbologa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 rhacs-docs-4.7 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kcarmichael08 @ocpdocs-previewbot @openshift-cherrypick-robot @vladbologa @jeana-redhat