Skip to content

OADP-5888 Add Line After Include Statements #93812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OADP-5888 Add Line After Include Statements #93812

wants to merge 3 commits into from

Conversation

Pkylas007
Copy link

@Pkylas007 Pkylas007 commented May 28, 2025 •
edited
Loading

Version(s):

  • OCP 4.20, 4.19

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Note -
As discussed with Kathryn, skipping the QE review because this PR focuses on adding a space after the include statements in modules and there are no technical changes.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 28, 2025 •
edited
Loading

🤖 Wed Jul 09 10:29:12 - Prow CI generated the docs preview:

https://93812--ocpdocs-pr.netlify.app/
https://93812--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-advanced-topics.html
https://93812--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-features-plugins.html
https://93812--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/release-notes/oadp-1-4-release-notes.html
https://93812--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/backup_and_restore/application_backup_and_restore/oadp-features-plugins.html
https://93812--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/backup_and_restore/application_backup_and_restore/release-notes/oadp-1-4-release-notes.html
https://93812--ocpdocs-pr.netlify.app/openshift-rosa/latest/backup_and_restore/application_backup_and_restore/oadp-features-plugins.html
https://93812--ocpdocs-pr.netlify.app/openshift-rosa/latest/backup_and_restore/application_backup_and_restore/release-notes/oadp-1-4-release-notes.html

@Pkylas007 Pkylas007 force-pushed the oadp-5888-space-after-include branch from 8a1cf5b to 3db2bd3 Compare June 25, 2025 09:07
@Pkylas007
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 26, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.19 branch/enterprise-4.20 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 26, 2025
@lahinson lahinson added this to the Continuous Release milestone Jun 26, 2025
lahinson
lahinson reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backup_and_restore/application_backup_and_restore/oadp-advanced-topics.adoc

[id="oadp-different-kubernetes-api-versions"]
== Working with different Kubernetes API versions on the same cluster

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of the scope of this PR, but this section needs a short introduction. Otherwise, you end up with one heading being displayed just after another heading.

backup_and_restore/application_backup_and_restore/oadp-advanced-topics.adoc
include::modules/oadp-using-enable-api-group-versions.adoc[leveloffset=+2]

[id="backing-up-data-one-cluster-restoring-another-cluster"]
== Backing up data from one cluster and restoring it to another cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above -- it would be good to add a short introduction here.

backup_and_restore/application_backup_and_restore/oadp-advanced-topics.adoc

[id="oadp-storage-class-mapping"]
== OADP storage class mapping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above -- it would be good to add a short introduction here.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 26, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

@Pkylas007: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

branch/enterprise-4.19 branch/enterprise-4.20 lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@Pkylas007 @ocpdocs-previewbot @openshift-bot @lahinson