Skip to content

OADP-5888 Add Line After Include Statements #93812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OADP-5888 Add Line After Include Statements #93812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db2bd3
OADP-5888 Add Line After Include Statements
May 28, 2025
65bfb2c
Merge branch 'main' into oadp-5888-space-after-include
Pkylas007 Jul 8, 2025
98defa4
Fixed validation errors
Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backup_and_restore/application_backup_and_restore/oadp-advanced-topics.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,31 @@ This document provides information about advanced features and functionalities o
== Working with different Kubernetes API versions on the same cluster

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of the scope of this PR, but this section needs a short introduction. Otherwise, you end up with one heading being displayed just after another heading.

include::modules/oadp-checking-api-group-versions.adoc[leveloffset=+2]

include::modules/oadp-about-enable-api-group-versions.adoc[leveloffset=+2]

include::modules/oadp-using-enable-api-group-versions.adoc[leveloffset=+2]

[id="backing-up-data-one-cluster-restoring-another-cluster"]
== Backing up data from one cluster and restoring it to another cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above -- it would be good to add a short introduction here.


include::modules/oadp-about-backing-and-restoring-from-cluster-to-cluster.adoc[leveloffset=+2]

include::modules/oadp-pod-volume-backup.adoc[leveloffset=+2]

include::modules/oadp-backing-up-opt-in.adoc[leveloffset=+3]

include::modules/oadp-backing-up-opt-out.adoc[leveloffset=+3]

include::modules/oadp-cluster-to-cluster-uid-and-gid-ranges.adoc[leveloffset=+2]

include::modules/oadp-backing-and-restoring-from-cluster-to-cluster.adoc[leveloffset=+2]

[id="oadp-storage-class-mapping"]
== OADP storage class mapping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above -- it would be good to add a short introduction here.

include::modules/oadp-storage-class-mapping.adoc[leveloffset=+2]

include::modules/oadp-storage-class-mapping-oadp.adoc[leveloffset=+3]

[role="_additional-resources"]
Expand Down
10 changes: 10 additions & 0 deletions backup_and_restore/application_backup_and_restore/oadp-features-plugins.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@ OpenShift API for Data Protection (OADP) features provide options for backing up
The default plugins enable Velero to integrate with certain cloud providers and to back up and restore {product-title} resources.

include::modules/oadp-features.adoc[leveloffset=+1]

include::modules/oadp-plugins.adoc[leveloffset=+1]

include::modules/oadp-configuring-velero-plugins.adoc[leveloffset=+1]

include::modules/oadp-plugins-receiving-eof-message.adoc[leveloffset=+2]


ifndef::openshift-rosa,openshift-rosa-hcp[]
include::modules/oadp-supported-architecture.adoc[leveloffset=+1]
endif::openshift-rosa,openshift-rosa-hcp[]
Expand All @@ -29,13 +35,17 @@ OpenShift API for Data Protection (OADP) is platform neutral. The information th


include::modules/oadp-ibm-power-test-support.adoc[leveloffset=+2]

include::modules/oadp-ibm-z-test-support.adoc[leveloffset=+2]

include::modules/oadp-ibm-power-and-z-known-issues.adoc[leveloffset=+3]

endif::openshift-rosa,openshift-rosa-hcp[]

include::modules/oadp-fips.adoc[leveloffset=+1]

include::modules/avoiding-the-velero-plugin-panic-error.adoc[leveloffset=+1]

include::modules/workaround-for-openshift-adp-controller-segmentation-fault.adoc[leveloffset=+1]

:!oadp-features-plugins:
5 changes: 5 additions & 0 deletions ...estore/application_backup_and_restore/release-notes/oadp-1-4-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,21 @@ For additional information about {oadp-short}, see link:https://access.redhat.co
====

include::modules/oadp-1-4-4-release-notes.adoc[leveloffset=+1]

include::modules/oadp-1-4-3-release-notes.adoc[leveloffset=+1]

include::modules/oadp-1-4-2-release-notes.adoc[leveloffset=+1]

[role="_additional-resources"]
.Additional resources
* xref:../../../backup_and_restore/application_backup_and_restore/backing_up_and_restoring/oadp-deleting-backups.adoc#oadp-about-kopia-repo-maintenance_deleting-backups[About Kopia repository maintenance]

include::modules/oadp-1-4-1-release-notes.adoc[leveloffset=+1]

include::modules/oadp-1-4-0-release-notes.adoc[leveloffset=+1]

include::modules/oadp-backing-up-dpa-configuration-1-4-0.adoc[leveloffset=+3]

include::modules/oadp-upgrading-oadp-operator-1-4-0.adoc[leveloffset=+3]

// TODO: Include this xref when the Operators book is added to the ROSA HCP docs.
Expand Down
22 changes: 22 additions & 0 deletions modules/oadp-adp-controller-segmentation.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Module included in the following assemblies:
//
// applications/projects/working-with-projects.adoc

:_mod-docs-content-type: PROCEDURE
[id="openshift-adp-controller-manager-seg-fault_{context}"]
= OpenShift ADP Controller segmentation fault

If you configure a DPA with both `cloudstorage` and `restic` enabled, the `openshift-adp-controller-manager` pod crashes and restarts indefinitely until the pod fails with a crash loop segmentation fault.

You can have either `velero` or `cloudstorage` defined, because they are mutually exclusive fields.

* If you have both `velero` and `cloudstorage` defined, the `openshift-adp-controller-manager` fails.
* If you have neither `velero` nor `cloudstorage` defined, the `openshift-adp-controller-manager` fails.

For more information about this issue, see link:https://issues.redhat.com/browse/OADP-1054[OADP-1054].


[id="openshift-adp-controller-manager-seg-fault-workaround_{context}"]
== OpenShift ADP Controller segmentation fault workaround

You must define either `velero` or `cloudstorage` when you configure a DPA. If you define both APIs in your DPA, the `openshift-adp-controller-manager` pod fails with a crash loop segmentation fault.
12 changes: 12 additions & 0 deletions modules/oadp-plugins-receiving-eof-message.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Module is included in the following assemblies:
//
// * openshift-docs/cicd/gitops/understanding-openshift-gitops.adoc

:_mod-docs-content-type: CONCEPT
[id="oadp-plugins-receiving-eof-message_{context}"]
= Velero plugins returning "received EOF, stopping recv loop" message

[NOTE]
====
Velero plugins are started as separate processes. After the Velero operation has completed, either successfully or not, they exit. Receiving a `received EOF, stopping recv` loop message in the debug logs indicates that a plugin operation has completed. It does not mean that an error has occurred.
====