OSDOC#43771 - Updates to NAD CLI configuration #98488
Conversation
openshift-ci
bot
added
the
size/S
jherrman
force-pushed
the
virt_bridge-mapping-updates-4.18_CNV-43771
branch
from
7ecf7ae to
146ea4c
Compare
| <6> Optionally, for more fine-grained network management, you can configure a virtual LAN (VLAN) ID for the NAD. VMs that use this NAD have an interface that can communicate only with devices that use the same VLAN ID (`200` in this example). | ||
| <7> The value of the `namespace` and `name` fields in the `metadata` stanza of the `NetworkAttachmentDefinition` object. | ||
| <5> The name of the host's physical network interface, to which the pod's new network interface will be attached. This setting can be reused by multiple NADs. Note that `physicalNetworkName` must match the value of the `spec.desiredState.ovn.bridge-mappings.localnet` field of the `NodeNetworkConfigurationPolicy` object that defines the OVS bridge mapping. | ||
| <6> Optional: The maximum transmission unit (MTU) value. If you do not set a value, the Cluster Network Operator (CNO) sets a default MTU value by calculating the difference among the underlay MTU of the primary network interface, the overlay MTU of the pod network, and byte capacity of any enabled features, such as IPsec. |
There was a problem hiding this comment.
🤖 [error] Vale.Terms: Use '(?<!.*-)operator' instead of 'Operator'.
sjhala-ccs
left a comment
sjhala-ccs
left a comment
There was a problem hiding this comment.
A couple of suggestions for your consideration. Looks good otherwise. In your PR description, it says this applies to 4.15-4.18. I am not sure if it is possible to cherry pick the changes to 4.15-4.17 if your feature branch is based off enterprise-4.18.
Applying SME review Kudos to Juan Orti for the feedback Apply suggestions from code review Co-authored-by: Shikha Jhala <sjhala@redhat.com>
jherrman
force-pushed
the
virt_bridge-mapping-updates-4.18_CNV-43771
branch
from
27773ba to
e763efe
Compare
|
@jherrman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@sjhala-ccs , thank you for the review and the suggestions, they definitely improved the content. I applied them and re-squashed, hopefully the changes are now merge-ready. As for the cherry-picks to 4.15-4.17, the impacted files look reasonably same-y across those versions, but if the automatic cherry-pick fails, I'll make separate PRs. Thanks again, |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
@sjhala-ccs: new pull request created: #99338 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: #98488 failed to apply on top of branch "enterprise-4.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: new pull request created: #99339 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.15 |
|
@sjhala-ccs: new pull request created: #99340 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Version(s):
4.15 - 4.18
Issue:
https://issues.redhat.com/browse/CNV-43771
Link to docs preview:
https://98488--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-ovn-secondary-network.html#virt-creating-localnet-nad-cli_virt-connecting-vm-to-ovn-secondary-network
QE review:
Additional information:
This is a 4.18-based copy of #97989