-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-16123]:Prune "CLI Tools" Phase 2 #98783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
466ee3c to
74e658a
Compare
|
🤖 Wed Sep 17 00:12:41 - Prow CI generated the docs preview: |
74e658a to
71d1710
Compare
| [IMPORTANT] | ||
| ==== | ||
| The method of authenticating using Red Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page. | ||
| The method of authenticating using Red{nbsp}Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.
| [IMPORTANT] | ||
| ==== | ||
| The method of authenticating using Red Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page. | ||
| The method of authenticating using Red{nbsp}Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.
381670b to
e7b44a9
Compare
|
/re-test |
| = Create objects | ||
|
|
||
| //Adding the following condition fpr pruning purposes. Once pruning complete, note should be removed from HCP docs and flag can be manually added to each create command (where applicable). | ||
| ifdef::openshift-rosa-hcp[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.
| $ rosa create admin --cluster=mycluster | ||
| ---- | ||
|
|
||
| ifdef::openshift-rosa-hcp[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the bot is incorrectly flagging this and following if statements as being unbalanced due to the one above that wasn't.
| |--additional-control-plane-security-group-ids <sec_group_id> | ||
| |The identifier of one or more additional security groups to use along with the default security groups that are used with the control plane nodes created alongside the cluster. For more information on additional security groups, see the requirements for _Security groups_ under _Additional resources_. | ||
|
|
||
| ifdef::openshift-rosa-hcp[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.
|
/retest |
ca0b4c2 to
005c81c
Compare
modules/rosa-configure.adoc
Outdated
| [id="rosa-login_{context}"] | ||
| == login | ||
| There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} (ROSA) CLI (`rosa`). These methods are described in detail below. | ||
| There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'log in to' rather than 'log into'. For more information, see RedHat.TermsErrors.
9ca9339 to
aa7aaac
Compare
AedinC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Mark. Just had some small nits around conditionals and attributes.
modules/rosa-about.adoc
Outdated
|
|
||
|
|
||
| Use the {product-title} (ROSA) command-line interface (CLI), the `rosa` command, to create, update, manage, and delete ROSA clusters and resources. | ||
| Use the {product-title} command-line interface (CLI) to create, update, manage, and delete {product-title} clusters and resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Use the {product-title} command-line interface (CLI) to create, update, manage, and delete {product-title} clusters and resources. | |
| Use the {rosa-cli-first} to create, update, manage, and delete {product-title} clusters and resources. |
| :_mod-docs-content-type: REFERENCE | ||
| [id="rosa-cli-classic-examples_{context}"] | ||
| = Least privilege permissions for common ROSA Classic CLI commands | ||
| = Least privilege permissions for common {product-title} CLI commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| = Least privilege permissions for common {product-title} CLI commands | |
| = Least privilege permissions for common {rosa-cli} commands |
modules/rosa-configure.adoc
Outdated
| = Configuring the ROSA CLI | ||
|
|
||
| Use the following commands to configure the {product-title} (ROSA) CLI, `rosa`. | ||
| Use the following commands to configure the {product-title} CLI, `rosa`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Use the following commands to configure the {product-title} CLI, `rosa`. | |
| Use the following commands to configure the {rosa-cli-first}. |
modules/rosa-configure.adoc
Outdated
| [id="rosa-login_{context}"] | ||
| == login | ||
| There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} (ROSA) CLI (`rosa`). These methods are described in detail below. | ||
| There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below. | |
| There are several methods you can use to log in to your Red{nbsp}Hat account using the {rosa-cli-first}. These methods are described in detail below. |
modules/rosa-using-bash-script.adoc
Outdated
|
|
||
|
|
||
| This is an example workflow of how to use a Bash script with the {product-title} (ROSA) CLI, `rosa`. | ||
| This is an example workflow of how to use a Bash script with the {product-title} CLI, `rosa`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This is an example workflow of how to use a Bash script with the {product-title} CLI, `rosa`. | |
| This is an example workflow of how to use a Bash script with the {rosa-cli-first}. |
| toc::[] | ||
|
|
||
| Managing objects with the {product-title} (ROSA) CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades. | ||
| Managing objects with the {product-title} CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Managing objects with the {product-title} CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades. | |
| Managing objects with the {rosa-cli-first}, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades. |
modules/rosa-common-commands.adoc
Outdated
| = Common commands and arguments | ||
|
|
||
| These common commands and arguments are available for the {product-title} (ROSA) CLI, `rosa`. | ||
| These common commands and arguments are available for the {product-title} CLI, `rosa`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| These common commands and arguments are available for the {product-title} CLI, `rosa`. | |
| These common commands and arguments are available for the {rosa-cli-first}. |
modules/rosa-parent-commands.adoc
Outdated
|
|
||
|
|
||
| The {product-title} (ROSA) CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands. | ||
| The {product-title} CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The {product-title} CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands. | |
| The {rosa-cli-first} uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest changing last sentence in line 8 to 'These policies contain only the minimum required permissions needed to perform specific actions by using the {rosa-cli-first}.'
modules/rosa-updating-rosa-cli.adoc
Outdated
|
|
||
| .Verification | ||
| * Verify that the new version of ROSA is installed. | ||
| * Verify that the new version of the ROSA CLI is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Verify that the new version of the ROSA CLI is installed. | |
| * Verify that the new version of the {rosa-cli} is installed. |
c8b3c4c to
12a18ba
Compare
b40c686 to
48a4be4
Compare
|
@mletalie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
@mletalie: new pull request created: #99177 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mletalie: new pull request created: #99178 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19+
Issue:
https://issues.redhat.com/browse/OSDOCS-16123
Link to docs preview:
Review CLI tools in Classic
Review CLI tools in ROSA
QE review:
Additional information: