Skip to content

Conversation

@mletalie
Copy link
Contributor

@mletalie mletalie commented Sep 9, 2025

Version(s):

4.19+
Issue:

https://issues.redhat.com/browse/OSDOCS-16123
Link to docs preview:

Review CLI tools in Classic
Review CLI tools in ROSA
QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 9, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2025
@mletalie mletalie changed the title Osdocs 16123 [OSDOCS-16123]:Prune "CLI Tools" Phase 2 Sep 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 9, 2025

🤖 Wed Sep 17 00:12:41 - Prow CI generated the docs preview:
https://98783--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2025
[IMPORTANT]
====
The method of authenticating using Red Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page.
The method of authenticating using Red{nbsp}Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.

[IMPORTANT]
====
The method of authenticating using Red Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page.
The method of authenticating using Red{nbsp}Hat single sign-on does not break any existing automations that rely on offline tokens. Red{nbsp}Hat recommends using link:https://console.redhat.com/iam/service-accounts[services accounts] for automation purposes. If you still need to use offline tokens for automation or other purposes, you can download the OpenShift Cluster Manager API token from the link:https://console.redhat.com/openshift/token[OpenShift Cluster Manager API Token] page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.

@mletalie mletalie force-pushed the OSDOCS-16123 branch 2 times, most recently from 381670b to e7b44a9 Compare September 12, 2025 15:13
@mletalie
Copy link
Contributor Author

/re-test

= Create objects

//Adding the following condition fpr pruning purposes. Once pruning complete, note should be removed from HCP docs and flag can be manually added to each create command (where applicable).
ifdef::openshift-rosa-hcp[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

$ rosa create admin --cluster=mycluster
----

ifdef::openshift-rosa-hcp[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the bot is incorrectly flagging this and following if statements as being unbalanced due to the one above that wasn't.

|--additional-control-plane-security-group-ids <sec_group_id>
|The identifier of one or more additional security groups to use along with the default security groups that are used with the control plane nodes created alongside the cluster. For more information on additional security groups, see the requirements for _Security groups_ under _Additional resources_.

ifdef::openshift-rosa-hcp[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

@mletalie
Copy link
Contributor Author

/retest

@mletalie mletalie force-pushed the OSDOCS-16123 branch 2 times, most recently from ca0b4c2 to 005c81c Compare September 15, 2025 15:25
[id="rosa-login_{context}"]
== login
There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} (ROSA) CLI (`rosa`). These methods are described in detail below.
There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'log in to' rather than 'log into'. For more information, see RedHat.TermsErrors.

Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Mark. Just had some small nits around conditionals and attributes.



Use the {product-title} (ROSA) command-line interface (CLI), the `rosa` command, to create, update, manage, and delete ROSA clusters and resources.
Use the {product-title} command-line interface (CLI) to create, update, manage, and delete {product-title} clusters and resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the {product-title} command-line interface (CLI) to create, update, manage, and delete {product-title} clusters and resources.
Use the {rosa-cli-first} to create, update, manage, and delete {product-title} clusters and resources.

:_mod-docs-content-type: REFERENCE
[id="rosa-cli-classic-examples_{context}"]
= Least privilege permissions for common ROSA Classic CLI commands
= Least privilege permissions for common {product-title} CLI commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= Least privilege permissions for common {product-title} CLI commands
= Least privilege permissions for common {rosa-cli} commands

= Configuring the ROSA CLI

Use the following commands to configure the {product-title} (ROSA) CLI, `rosa`.
Use the following commands to configure the {product-title} CLI, `rosa`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the following commands to configure the {product-title} CLI, `rosa`.
Use the following commands to configure the {rosa-cli-first}.

[id="rosa-login_{context}"]
== login
There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} (ROSA) CLI (`rosa`). These methods are described in detail below.
There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are several methods you can use to log into your Red{nbsp}Hat account using the {product-title} CLI (`rosa`). These methods are described in detail below.
There are several methods you can use to log in to your Red{nbsp}Hat account using the {rosa-cli-first}. These methods are described in detail below.



This is an example workflow of how to use a Bash script with the {product-title} (ROSA) CLI, `rosa`.
This is an example workflow of how to use a Bash script with the {product-title} CLI, `rosa`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is an example workflow of how to use a Bash script with the {product-title} CLI, `rosa`.
This is an example workflow of how to use a Bash script with the {rosa-cli-first}.

toc::[]

Managing objects with the {product-title} (ROSA) CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades.
Managing objects with the {product-title} CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Managing objects with the {product-title} CLI, `rosa`, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades.
Managing objects with the {rosa-cli-first}, such as adding `dedicated-admin` users, managing clusters, and scheduling cluster upgrades.

= Common commands and arguments

These common commands and arguments are available for the {product-title} (ROSA) CLI, `rosa`.
These common commands and arguments are available for the {product-title} CLI, `rosa`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These common commands and arguments are available for the {product-title} CLI, `rosa`.
These common commands and arguments are available for the {rosa-cli-first}.



The {product-title} (ROSA) CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands.
The {product-title} CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The {product-title} CLI, `rosa`, uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands.
The {rosa-cli-first} uses parent commands with child commands to manage objects. The parent commands are `create`, `edit`, `delete`, `list`, and `describe`. Not all parent commands can be used with all child commands. For more information, see the specific reference topics that describes the child commands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing last sentence in line 8 to 'These policies contain only the minimum required permissions needed to perform specific actions by using the {rosa-cli-first}.'


.Verification
* Verify that the new version of ROSA is installed.
* Verify that the new version of the ROSA CLI is installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Verify that the new version of the ROSA CLI is installed.
* Verify that the new version of the {rosa-cli} is installed.

@mletalie mletalie force-pushed the OSDOCS-16123 branch 2 times, most recently from c8b3c4c to 12a18ba Compare September 16, 2025 21:10
@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2025

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mletalie mletalie merged commit d5843f7 into openshift:main Sep 17, 2025
2 checks passed
@mletalie
Copy link
Contributor Author

/cherrypick enterprise-4.19

@mletalie
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@mletalie: new pull request created: #99177

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mletalie: new pull request created: #99178

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants