Skip to content

Conversation

@bergerhoffer bergerhoffer added this to the Planned for 4.20 GA milestone Sep 10, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor Author

@ingvagabund @zhouying7780 Can you PTAL and make sure it's correct that I'm removing these unsupported OSSO versions for 4.20 - and then once 1.5.0 goes out after 4.20 GA, we'll have a supported version here.

@ingvagabund
Copy link
Member

Yes. This looks right. Anything below 1.5 => /dev/null.
LGTM

@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@bergerhoffer
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 18, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 18, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergerhoffer LGTM. You might want to double-check the preview for the release notes file and the uninstalling file. In the preview, the attributes in the titles of those files aren't rendering. Not sure if that's an attribute issue or expected behavior in the preview.

@lahinson lahinson removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 18, 2025
@bergerhoffer
Copy link
Contributor Author

@bergerhoffer LGTM. You might want to double-check the preview for the release notes file and the uninstalling file. In the preview, the attributes in the titles of those files aren't rendering. Not sure if that's an attribute issue or expected behavior in the preview.

You know what, I just saw that in another PR's preview. I wonder if someone accidentally removed something that is impacting the doc set...

@bergerhoffer bergerhoffer merged commit a490ced into openshift:main Sep 22, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #99500

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants