-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#15350: Removing unsupported OSSO versions for 4.20 #98852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@ingvagabund @zhouying7780 Can you PTAL and make sure it's correct that I'm removing these unsupported OSSO versions for 4.20 - and then once 1.5.0 goes out after 4.20 GA, we'll have a supported version here. |
|
Yes. This looks right. Anything below 1.5 => /dev/null. |
|
/lgtm |
|
/label merge-review-needed |
lahinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergerhoffer LGTM. You might want to double-check the preview for the release notes file and the uninstalling file. In the preview, the attributes in the titles of those files aren't rendering. Not sure if that's an attribute issue or expected behavior in the preview.
You know what, I just saw that in another PR's preview. I wonder if someone accidentally removed something that is impacting the doc set... |
|
/cherrypick enterprise-4.20 |
|
@bergerhoffer: new pull request created: #99500 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-15350
Link to docs preview:
https://98852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/secondary_scheduler/index.html
https://98852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/secondary_scheduler/nodes-secondary-scheduler-configuring.html
https://98852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/secondary_scheduler/nodes-secondary-scheduler-release-notes.html
https://98852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/secondary_scheduler/nodes-secondary-scheduler-uninstalling.html
QE review:
Additional information: