Skip to content

CNV#55754_02: Misc 4.20 RN fixes#99145

Merged
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.20from
danielclowers:CNV-57754_02
Sep 25, 2025
Merged

CNV#55754_02: Misc 4.20 RN fixes#99145
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.20from
danielclowers:CNV-57754_02

Conversation

@danielclowers
Copy link
Contributor

@danielclowers danielclowers commented Sep 16, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 16, 2025

🤖 Wed Sep 24 15:25:37 - Prow CI generated the docs preview:

https://99145--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html

Copy link

@aspauldi aspauldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a couple of teeny comments.

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few tiny fixes, but otherwise it's looking good!

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2025

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is ready for merge as is, but this might be a good time to fix this release note if you are up for it. It's missing a bullet point * and the text is not in line with our style guidelines. These issues somehow slipped through the original PR review.

@sjhala-ccs
Copy link
Contributor

Merging this PR. Based on my conversation with @danielclowers on Slack, the remaining changes will be handled in a separate PR.

@sjhala-ccs sjhala-ccs merged commit 6ecfe2e into openshift:enterprise-4.20 Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 CNV Label for all CNV PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants