-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fixing some typos #99927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some typos #99927
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jldohmann @ShaunaDiaz It looks like the Vale rule for discrete headings didn't fire for this file. Any thoughts on why it didn't catch this? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ Policies defined using the `AdminNetworkPolicy` API take precedence over all oth | |
| + | ||
| Policies defined using the `BaselineAdminNetworkPolicy` API apply only when no other network policy overrides them. When you use the `AdminNetworkPolicy` API to delegate an aspect of network policy to the namespace-scoped `NetworkPolicy`, you should also define a sensible minimum restriction in the `BaselineAdminNetworkPolicy`. This ensures a baseline level of network security at the cluster level in case the `NetworkPolicy` for a namespace does not provide sufficient protection. | ||
|
|
||
| Namespace-scoped network policy:: Application developers and namespace tenants can use the `NetworkPolicy` API to define network policy rules for a specific namespace. Rules in the `NetworkPolicy` for a namespace take precedence over cluster-wide rules configured using the BaselineAdminNetworkPolicy API, or for a cluster-wide rule that that has been delegated or "passed" from the cluster-wide `AdminNetworkPolicy` API. | ||
| Namespace-scoped network policy:: Application developers and namespace tenants can use the `NetworkPolicy` API to define network policy rules for a specific namespace. Rules in the `NetworkPolicy` for a namespace take precedence over cluster-wide rules configured using the BaselineAdminNetworkPolicy API, or for a cluster-wide rule that has been delegated or "passed" from the cluster-wide `AdminNetworkPolicy` API. | ||
|
|
||
| [discrete] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bergerhoffer do you mean here? it's not a part of the git diff, so the CI will not check against it
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jldohmann I do. Lines 11 and 22. I thought it would check on the whole file. Does it really only check against lines you change?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. vale will run on the whole file, but the output gets filtered using
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'm uncertain if changing things so that all alerts are reflected in PR comments is possible, based on the GH API the prow script uses: there's a comment that says the GH API only accepts comments within the diff for the review comments endpoint
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I'm not saying we need to change it. I just want to make sure I understand exactly what it's doing so that we can make sure everyone else is aware as well. For some reason, I thought I had made a change to a file elsewhere and it picked something up. I'll check back through my test PRs to see if I can find what I'm talking about. Thanks! |
||
| == How network policy is evaluated and applied | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.