Skip to content

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Oct 2, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Link to docs preview:

https://99954--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage_security_policies/custom-security-policies.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from c6698e1 to 6e5c455 Compare October 16, 2025 14:40
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from 6e5c455 to bb433b9 Compare October 16, 2025 18:32
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Links to docs previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch 2 times, most recently from 7dcc689 to c9d6aa5 Compare October 16, 2025 19:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Links to docs previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 labels Oct 16, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch 3 times, most recently from 82d5cd3 to f568f23 Compare October 20, 2025 14:38
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Links to docs previews:

QE review: ACS has no QE, approved by SMEs

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from f568f23 to 8fbb456 Compare October 20, 2025 15:39
@kcarmichael08
Copy link
Contributor Author

/retest

2 similar comments
@kcarmichael08
Copy link
Contributor Author

/retest

@kcarmichael08
Copy link
Contributor Author

/retest

@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from 8fbb456 to 79b7ab5 Compare October 20, 2025 19:33
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@kcarmichael08: This pull request references ROX-19928 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issues:

Links to docs previews:

QE review: ACS has no QE, approved by SMEs

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@knortema knortema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these comments are teeny nitpicky things, plus I have a couple of questions about the use of quotes. There are lots of things to keep in mind here, and I wish I knew the subject matter better so I could be of better help.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from 79b7ab5 to cef80d7 Compare October 21, 2025 19:52
@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch 2 times, most recently from 1b26b98 to fdcdc0e Compare October 21, 2025 20:15
@kcarmichael08 kcarmichael08 force-pushed the ROX-19928-policy-doc-updates branch from fdcdc0e to a91033a Compare October 21, 2025 20:31
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit e1e379f into openshift:rhacs-docs-main Oct 22, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.9

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #100937

In response to this:

/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants