Skip to content

OPRUN-4607: Remove test-experimenal-e2e#732

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:remote-experimental-e2e
May 21, 2026
Merged

OPRUN-4607: Remove test-experimenal-e2e#732
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:remote-experimental-e2e

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented May 20, 2026

It's no longer bring used.

This can be removed since openshift/release#79473 merged.

Summary by CodeRabbit

  • Chores
    • Updated testing configuration to streamline end-to-end test execution: removed the experimental e2e target and consolidated its behavior into the primary e2e target, which now runs with additional platform-specific and tagged test options to ensure the intended suites run consistently.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 20, 2026

@tmshort: This pull request references OPRUN-4607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

It's no longer bring used.

This can be removed since openshift/release#79473 merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 795bda57-f3c1-460f-b002-533084ae35a7

📥 Commits

Reviewing files that changed from the base of the PR and between e1ff989 and e471d75.

📒 Files selected for processing (1)
  • openshift/Makefile
💤 Files with no reviewable changes (1)
  • openshift/Makefile

Walkthrough

The openshift/Makefile consolidates e2e testing: test-e2e now invokes go test with --godog.tags and --k8s.cli=oc, and the test-experimental-e2e phony target is removed.

Changes

E2E test targets

Layer / File(s) Summary
E2E test target consolidation
openshift/Makefile
The test-e2e target is updated to include --godog.tags and --k8s.cli=oc flags in the go test invocation. The test-experimental-e2e phony target is removed.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • openshift/operator-framework-operator-controller#723: Both PRs modify openshift/Makefile's test-e2e/test-experimental-e2e targets—updating test-e2e's go test invocation to include --godog.tags and --k8s.cli=oc, and touching the test-experimental-e2e behavior—so the changes overlap at the make target/command-line level.

Suggested labels

lgtm

Suggested reviewers

  • fgiudici
  • perdasilva
🚥 Pre-merge checks | ✅ 5 | ❌ 7

❌ Failed checks (7 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: removing the test-experimental-e2e make target, though it contains a typo ('experimenal' instead of 'experimental').
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bentito and joelanford May 20, 2026 20:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
It's no longer bring used.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort force-pushed the remote-experimental-e2e branch from e1ff989 to e471d75 Compare May 20, 2026 20:09
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented May 20, 2026

/test openshift-e2e-aws-techpreview

@joelanford
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented May 21, 2026

/verified by @dtfranz

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@dtfranz: This PR has been marked as verified by @dtfranz.

Details

In response to this:

/verified by @dtfranz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bandrade
Copy link
Copy Markdown
Contributor

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 21, 2026

@tmshort: This pull request references OPRUN-4607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

It's no longer bring used.

This can be removed since openshift/release#79473 merged.

Summary by CodeRabbit

  • Chores
  • Updated testing configuration to streamline end-to-end test execution: removed the experimental e2e target and consolidated its behavior into the primary e2e target, which now runs with additional platform-specific and tagged test options to ensure the intended suites run consistently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3d91cab into openshift:main May 21, 2026
15 checks passed
@tmshort tmshort deleted the remote-experimental-e2e branch May 21, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants