OPRUN-4607: Remove test-experimental-e2e from techpreview#79473
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tmshort: This pull request references OPRUN-4607 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse auto-ack |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
WalkthroughFour CI operator configuration files for the operator-framework-operator-controller project are updated to run the standard E2E test suite instead of the experimental variant in the Tech Preview workflow step across main and release branches 4.23, 5.0, and 5.1. ChangesE2E test target update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
tmshort
force-pushed
the
remove-experimental-e2e
branch
from
fda6e21 to
c3479e3
Compare
|
/pj-rehearse auto-ack |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
The optional techpreview jobs may not pass until openshift/operator-framework-operator-controller#726 merges... |
|
/jp-rehearse auto-ack |
|
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-release-4.23-openshift-e2e-aws-techpreview |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tmshort: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
2 similar comments
|
@tmshort: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@tmshort: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tmshort: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
1 similar comment
|
@tmshort: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-release-5.1-openshift-e2e-aws-techpreview |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-release-5.0-openshift-e2e-aws-techpreview |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
When running the openshift-e2e-aws-techpreview CI, both the test-e2e and test-experimental-e2e targets are run. This is redundant, as the upstream e2e looks at the enabled feature flags to determine which tests to run. So, the test-experimental-e2e wasn't doing anything special. This now just runs the test-e2e target. Signed-off-by: Todd Short <todd.short@me.com>
tmshort
force-pushed
the
remove-experimental-e2e
branch
from
c3479e3 to
8f89bb1
Compare
|
/pj-rehearse auto-ack |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
The upstream-e2e passed in main/4.23/5.0. The install failed in 5.1, not an issue with my changes. |
|
/label qe-approved |
openshift-ci
Bot
added
the
qe-approved
openshift-ci-robot
added
the
verified
|
@bandrade: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, pedjak, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack But it had passed the upstream-e2e, which is the area of change here. |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/override ci/rehearse/openshift/operator-framework-operator-controller/main/openshift-e2e-aws-techpreview |
|
/override ci/rehearse/openshift/operator-framework-operator-controller/release-5.1/openshift-e2e-aws-techpreview |
|
@tmshort: tmshort unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: tmshort unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
merged commit 6ad0dd9
into
openshift:main
6 participants
When running the openshift-e2e-aws-techpreview CI, both the test-e2e and test-experimental-e2e targets are run. This is redundant, as the upstream e2e looks at the enabled feature flags to determine which tests to run. So, the test-experimental-e2e wasn't doing anything special.
This now just runs the test-e2e target.
Summary
This PR updates the OpenShift CI configuration for the operator-framework-operator-controller component (ci-operator configs in the openshift/release repo) so the optional openshift-e2e-aws-techpreview job runs only the upstream test-e2e make target. The redundant invocation of make -C openshift test-experimental-e2e was removed; the job now invokes make -C openshift test-e2e exclusively.
Rationale
The upstream e2e harness controls which tests run via feature flags (FEATURE_SET: TechPreviewNoUpgrade). test-experimental-e2e provided no additional behavior, so running both targets was redundant.
Affected configuration
ci-operator configs modified for the operator-framework-operator-controller component:
Each file’s openshift-e2e-aws-techpreview optional step was changed to run make -C openshift test-e2e instead of make -C openshift test-experimental-e2e.
Impact
Pure CI configuration change; no API, production code, or exported/public interface changes. The CI job will continue to run E2E tests under the same cluster profile and FEATURE_SET, with the duplicate experimental target removed.