This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Routing SPI: Send notifications on rollbacks - #6058
Merged
openshift-bot merged 1 commit intoFeb 7, 2015
Merged
Conversation
Add rollback methods to NotifyAliasAddOp, NotifyAppCreateOp, and NotifySslCertAddOp. These rollback methods invoke the notify_remove_alias, notify_delete_application, and notify_ssl_cert_remove methods, respectively, of the routing service. This change causes the ActiveMQ routing plug-in to send :remove_alias, :delete_application, and :remove_ssl notifications when an application creation fails so that anything listening for these notifications (such as the OpenShift routing daemon) can properly clean up any configuration that it may have done in response to the earlier corresponding :add_alias, :create_application, and :add_ssl notifications during the application's creation. This commit fixes bug 1186036.
Contributor
Author
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8631/) |
Contributor
|
LGTM |
Contributor
Author
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8631/) (Image: devenv_5423) |
|
Evaluated for online up to 51dbfed |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 7, 2015
…ifications-on-rollbacks Merged by openshift-bot
Contributor
Author
|
Wow, that took a while. Thanks, openshift-bot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rollback methods to
NotifyAliasAddOp,NotifyAppCreateOp, andNotifySslCertAddOp. These rollback methods invoke thenotify_remove_alias,notify_delete_application, andnotify_ssl_cert_removemethods, respectively, of the routing service.This change causes the ActiveMQ routing plug-in to send
:remove_alias,:delete_application, and:remove_sslnotifications when an application creation fails so that anything listening for these notifications (such as the OpenShift routing daemon) can properly clean up any configuration that it may have done in response to the earlier corresponding:add_alias,:create_application, and:add_sslnotifications during the application's creation.This commit fixes bug 1186036.