[Conformance][templates] templateinstance impersonation tests should pass impersonation creation tests [Suite:openshift/conformance/parallel]

[mfojtik]

Details: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16652/test_pull_request_origin_extended_conformance_install_update/7228/

Expected error:
    <*errors.StatusError | 0xc421d33b80>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {SelfLink: "", ResourceVersion: ""},
            Status: "Failure",
            Message: "TemplateInstance.template.openshift.io \"test\" is invalid: spec.requester.username: Forbidden: you do not have permission to set username",
            Reason: "Invalid",
            Details: {
                Name: "test",
                Group: "template.openshift.io",
                Kind: "TemplateInstance",
                UID: "",
                Causes: [
                    {
                        Type: "FieldValueForbidden",
                        Message: "Forbidden: you do not have permission to set username",
                        Field: "spec.requester.username",
                    },
                ],
                RetryAfterSeconds: 0,
            },
            Code: 422,
        },
    }
    TemplateInstance.template.openshift.io "test" is invalid: spec.requester.username: Forbidden: you do not have permission to set username
not to have occurred

[gabemontero]

passes for me locally with a fresh build after rebasing from origin master this AM, so certainly seems like a flake vs. full on regression

[gabemontero]

oh, and the failure was with the impersonatebygroupuser user on should pass impersonation creation tests

the adminuser test and impersonateuser tests did pass impersonation creation

[gabemontero]

Potentially, the associated errors in the master log (at least they occur during the time frame of the failed test):

Oct 03 10:22:30 ip-172-18-8-35.ec2.internal origin-master-controllers[40722]: E1003 10:22:30.624748   40722 templateinstance_controller.go:205] TemplateInstance status update failed: Operation cannot be fulfilled on templateinstances.template.openshift.io "test": StorageError: invalid object, Code: 4, Key: /openshift.io/templateinstances/extended-test-templates-9k802-09jr4/test, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: c33feada-a824-11e7-9e82-0e9974b6f60a, UID in object meta:
Oct 03 10:22:30 ip-172-18-8-35.ec2.internal origin-master-controllers[40722]: E1003 10:22:30.624763   40722 templateinstance_controller.go:325] TemplateInstance extended-test-templates-9k802-09jr4/test failed with: Operation cannot be fulfilled on templateinstances.template.openshift.io "test": StorageError: invalid object, Code: 4, Key: /openshift.io/templateinstances/extended-test-templates-9k802-09jr4/test, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: c33feada-a824-11e7-9e82-0e9974b6f60a, UID in object meta:

[gabemontero]

re: chat with @jim-minter on IRC the above error logs are not relevant ... basic benign concurrent access noise

[gabemontero]

also, @jim-minter discovered an apparent journald gap wrt API/REST invocations during the error window.

[jim-minter]

I haven't a clue what's causing this, and I think our logs are useless because of journald rate limiting. openshift/openshift-ansible#5642. @bparees fyi.