wait for group cache in templateinstance tests

[jim-minter]

fixes #16654

(builds on #16979)

@gabemontero fyi

[gabemontero]

So is a fair summary:

1. validation had to be augmented to deal with garbage collection mutation of the object based on the client it uses and by extension the serialization used
2. extended tests needed to be augmented to better ensure data was in fact deleted between one test run and the next

thanks

[jim-minter]

@gabemontero I think there were three issues causing flakes:

1. not waiting for group cache to sync after changing group memberships (affected two tests, causing permissions problems)
   2a) not waiting for cascading deletion to complete before trying to reinstantiate an identical object (caused rare unexpected AlreadyExists errors)
   2b) GC sometimes reordered json fields when removing the finaliser on the templateinstance, causing the update to be rejected by the api server, causing knock-on strangeness to happen on cascaded deletion (hence changes to validation logic)

2a 2b are already on the merge queue at #16979, this just builds upon that commit.

[gabemontero]

On Mon, Oct 23, 2017 at 4:28 PM, Jim Minter ***@***.***> wrote: @gabemontero <https://github.com/gabemontero> I think there were three issues causing flakes: 1. not waiting for group cache to sync after changing group memberships (affected two tests, causing permissions problems) 2a) not waiting for cascading deletion to complete before trying to reinstantiate an identical object (caused rare unexpected AlreadyExists errors) 2b) GC sometimes reordered json fields when removing the finaliser on the templateinstance, causing the update to be rejected by the api server, causing knock-on strangeness to happen on cascaded deletion (hence changes to validation logic) 2a 2b are already on the merge queue at #16979 <#16979>, this just builds upon that commit.

gotcha ... ok that break down helps after revisiting the changes - thanks

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17009 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADbadEou_XvaNhWM7ZLondQmxcmfA49Aks5svPbRgaJpZM4QDZP3> .

[stevekuznetsov]

/test origin-ut

[bparees]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• pkg/template/OWNERS [bparees]
• test/extended/OWNERS [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17007, 17003, 17001, 17009).