node configuration dump on server startup in tests is useless and annoying

[stevekuznetsov]

@smarterclayton please defend if you'd like to keep it. This is what I just got starting an extended test on my machine:

apiserver(nodes): {
  "kind": "Node",
  "apiVersion": "v1",
  "metadata": {
    "name": "10.13.137.174",
    "selfLink": "/api/v1/nodes/10.13.137.174",
    "uid": "da578c35-d020-11e5-8d38-54ee753e2644",
    "resourceVersion": "235",
    "creationTimestamp": "2016-02-10T18:05:22Z",
    "labels": {
      "kubernetes.io/hostname": "10.13.137.174"
    }
  },
  "spec": {
    "externalID": "10.13.137.174"
  },
  "status": {
    "capacity": {
      "cpu": "8",
      "memory": "16114980Ki",
      "pods": "40"
    },
    "allocatable": {
      "cpu": "8",
      "memory": "16114980Ki",
      "pods": "40"
    },
    "conditions": [
      {
        "type": "OutOfDisk",
        "status": "False",
        "lastHeartbeatTime": "2016-02-10T18:05:22Z",
        "lastTransitionTime": "2016-02-10T18:05:22Z",
        "reason": "KubeletHasSufficientDisk",
        "message": "kubelet has sufficient disk space available"
      },
      {
        "type": "Ready",
        "status": "True",
        "lastHeartbeatTime": "2016-02-10T18:05:22Z",
        "lastTransitionTime": "2016-02-10T18:05:22Z",
        "reason": "KubeletReady",
        "message": "kubelet is posting ready status"
      }
    ],
    "addresses": [
      {
        "type": "LegacyHostIP",
        "address": "10.13.137.174"
      },
      {
        "type": "InternalIP",
        "address": "10.13.137.174"
      }
    ],
    "daemonEndpoints": {
      "kubeletEndpoint": {
        "Port": 10250
      }
    },
    "nodeInfo": {
      "machineID": "ebd2eb9b1f1c4e759c2503351aea3b7c",
      "systemUUID": "0144BEFF-4F54-CB11-AAB0-9E9DBEE56318",
      "bootID": "9e753f33-3bf9-471c-ae32-8ed59fe8bace",
      "kernelVersion": "4.1.6-100.fc21.x86_64",
      "osImage": "Fedora 21 (Twenty One)",
      "containerRuntimeVersion": "docker://1.8.1-fc21",
      "kubeletVersion": "v1.2.0-origin",
      "kubeProxyVersion": "v1.2.0-origin"
    },
    "images": [
      {
        "repoTags": [
          "stevekuznetsov/resourcemanager:latest"
        ],
        "size": 671549520
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 671549520
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 662318310
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 662208157
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 662208157
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 646257066
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 646257066
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 669053378
      },
      {
        "repoTags": [
          "stevekuznetsov/postgresql-wcontrib:latest"
        ],
        "size": 401599692
      },
      {
        "repoTags": [
          "\u003cnone\u003e:\u003cnone\u003e"
        ],
        "size": 402165247
      },
      {
        "repoTags": [
          "docker.io/centos/postgresql-94-centos7:latest"
        ],
        "size": 298495513
      },
      {
        "repoTags": [
          "docker.io/openshift/postgresql-92-centos7:latest"
        ],
        "size": 297943273
      },
      {
        "repoTags": [
          "172.30.101.193:5000/openldap/openldap-testenv:latest",
          "172.30.66.184:5000/openldap/openldap-testenv:latest"
        ],
        "size": 289096873
      },
      {
        "repoTags": [
          "docker.io/centos:centos7"
        ],
        "size": 196634330
      },
      {
        "repoTags": [],
        "size": 261400818
      },
      {
        "repoTags": [
          "172.30.124.200:5000/cache/ruby-22-centos7:latest",
          "172.30.82.121:5000/cache/ruby-22-centos7:latest",
          "172.30.89.82:5000/cache/ruby-22-centos7:latest",
          "172.30.170.187:5000/cache/ruby-22-centos7:latest",
          "docker.io/centos/ruby-22-centos7:latest",
          "172.30.252.149:5000/cache/ruby-22-centos7:latest",
          "172.30.45.149:5000/cache/ruby-22-centos7:latest",
          "172.30.115.192:5000/cache/ruby-22-centos7:latest",
          "172.30.252.167:5000/cache/ruby-22-centos7:latest",
          "172.30.55.86:5000/cache/ruby-22-centos7:latest",
          "172.30.140.67:5000/cache/ruby-22-centos7:latest",
          "172.30.105.195:5000/cache/ruby-22-centos7:latest",
          "172.30.167.98:5000/cache/ruby-22-centos7:latest",
          "172.30.41.249:5000/cache/ruby-22-centos7:latest",
          "172.30.192.92:5000/cache/ruby-22-centos7:latest",
          "172.30.130.59:5000/cache/ruby-22-centos7:latest",
          "172.30.27.97:5000/cache/ruby-22-centos7:latest",
          "172.30.129.205:5000/cache/ruby-22-centos7:latest",
          "172.30.94.142:5000/cache/ruby-22-centos7:latest",
          "172.30.211.7:5000/cache/ruby-22-centos7:latest",
          "172.30.0.70:5000/cache/ruby-22-centos7:latest"
        ],
        "size": 540788760
      },
      {
        "repoTags": [],
        "size": 261400818
      },
      {
        "repoTags": [],
        "size": 261400818
      },
      {
        "repoTags": [],
        "size": 261400818
      },
      {
        "repoTags": [],
        "size": 261400818
      },
      {
        "repoTags": [],
        "size": 261400650
      },
      {
        "repoTags": [],
        "size": 261400827
      },
      {
        "repoTags": [],
        "size": 261400827
      },
      {
        "repoTags": [],
        "size": 261400827
      },
      {
        "repoTags": [
          "172.30.160.26:5000/openldap/openldap:latest"
        ],
        "size": 295977786
      },
      {
        "repoTags": [],
        "size": 295977786
      },
      {
        "repoTags": [],
        "size": 261400885
      },
      {
        "repoTags": [],
        "size": 261400885
      },
      {
        "repoTags": [],
        "size": 261400885
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261400581
      },
      {
        "repoTags": [],
        "size": 261395821
      },
      {
        "repoTags": [],
        "size": 261395821
      },
      {
        "repoTags": [],
        "size": 261393565
      },
      {
        "repoTags": [],
        "size": 261393565
      },
      {
        "repoTags": [],
        "size": 261393565
      },
      {
        "repoTags": [],
        "size": 261393565
      }
    ]
  }
}

[smarterclayton]

It's fine to only print if an error. And fine to remove.

[stevekuznetsov]

We'll fail if we can't set up the node. Config is saved and downloaded as an artifact as it is.

[stevekuznetsov]

/cc @enj