Skip to content

Separate events between upstream deployment and downstream rc controller #8630

@0xmichalis

Description

@0xmichalis

Deployment events from the upstream deployment controller are emitted using the "deployment-controller" name for the name of the component that emits them[1]. We currently use the same name for our deployment controller[2]. Two options: either 1) we don't care about this at all or 2) we change our controller's name.

cc: @ironcladlou @smarterclayton

[1] https://github.com/kubernetes/kubernetes/blob/9db45590cfaa0ae5cb658e49b70e443324b2d6c7/pkg/controller/deployment/deployment_controller.go#L102
[2]

recorder: eventBroadcaster.NewRecorder(kapi.EventSource{Component: "deployment-controller"}),

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions