Make import image more efficient#10244
Conversation
Fetch manifest directly by tag without resolving it first.
This also works around satellite not setting Content-Type on
`GET /v2/<name>/manifests/<reference>`
Signed-off-by: Michal Minář <miminar@redhat.com>
|
Evaluated for origin test up to f771f0c |
|
This is backwards compatible with old docker registries? |
Docker daemon uses it https://github.com/docker/docker/blob/master/distribution/pull_v2.go#L340. In the upstream API v2 spec, the support for manifest fetching using digest or tag appears to be from the very beginning: https://github.com/docker/distribution/blob/v2.0.0/docs/spec/api.md#pulling-an-image-manifest |
|
Ok, just wanted to be sure. On Fri, Aug 5, 2016 at 12:32 PM, Michal Minář notifications@github.com
|
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/) |
|
LGTM [merge] |
|
Evaluated for origin merge up to f771f0c |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/) (Image: devenv-rhel7_4789) |
Fetch manifest directly by tag without resolving it first.
This also works around satellite registry not setting
Content-TypeonGET /v2/<name>/manifests/<reference>.