Skip to content

Make import image more efficient#10244

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
miminar:more-efficient-image-import
Aug 9, 2016
Merged

Make import image more efficient#10244
openshift-bot merged 1 commit intoopenshift:masterfrom
miminar:more-efficient-image-import

Conversation

@miminar
Copy link
Copy Markdown

@miminar miminar commented Aug 5, 2016

Fetch manifest directly by tag without resolving it first.

This also works around satellite registry not setting Content-Type on GET /v2/<name>/manifests/<reference>.

Fetch manifest directly by tag without resolving it first.

This also works around satellite not setting Content-Type on

    `GET /v2/<name>/manifests/<reference>`

Signed-off-by: Michal Minář <miminar@redhat.com>
@miminar
Copy link
Copy Markdown
Author

miminar commented Aug 5, 2016

[test]

/cc @soltysh, @legionus

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin test up to f771f0c

@smarterclayton
Copy link
Copy Markdown
Contributor

This is backwards compatible with old docker registries?

@miminar
Copy link
Copy Markdown
Author

miminar commented Aug 5, 2016

This is backwards compatible with old docker registries?

Docker daemon uses it https://github.com/docker/docker/blob/master/distribution/pull_v2.go#L340.

In the upstream API v2 spec, the support for manifest fetching using digest or tag appears to be from the very beginning: https://github.com/docker/distribution/blob/v2.0.0/docs/spec/api.md#pulling-an-image-manifest

@smarterclayton
Copy link
Copy Markdown
Contributor

Ok, just wanted to be sure.

On Fri, Aug 5, 2016 at 12:32 PM, Michal Minář notifications@github.com
wrote:

This is backwards compatible with old docker registries?

Docker daemon uses it
https://github.com/docker/docker/blob/master/distribution/pull_v2.go#L340.

In the upstream API v2 spec, the support for manifest fetching using
digest or tag appears to be from the very beginning:
https://github.com/docker/distribution/blob/v2.0.0/docs/spec/api.md#pulling-an-image-manifest


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10244 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p31tsvMrfFMUA7wxeFw2hIJ3po9fks5qc2W0gaJpZM4Jd1US
.

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/)

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Aug 9, 2016

LGTM [merge]

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin merge up to f771f0c

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 9, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/) (Image: devenv-rhel7_4789)

@openshift-bot openshift-bot merged commit 60e3ec7 into openshift:master Aug 9, 2016
@miminar miminar deleted the more-efficient-image-import branch August 17, 2016 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants