Skip to content

don't expose oapi types as 'all'#18476

Merged
openshift-merge-robot merged 1 commit into
openshift:release-3.7from
juanvallejo:backport-origin-pr-18085-limit-all
Feb 9, 2018
Merged

don't expose oapi types as 'all'#18476
openshift-merge-robot merged 1 commit into
openshift:release-3.7from
juanvallejo:backport-origin-pr-18085-limit-all

Conversation

@juanvallejo

@juanvallejo juanvallejo commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

cc @deads2k

Backport of #18085

Addresses #18473 (comment)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2018
@deads2k

deads2k commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

clean pick?

@juanvallejo

Copy link
Copy Markdown
Contributor Author

@deads2k

clean pick?

Yeah

@juanvallejo

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@juanvallejo

Copy link
Copy Markdown
Contributor Author

/retest

@deads2k

deads2k commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

if it's a clean pick

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@openshift-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@juanvallejo

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@juanvallejo

Copy link
Copy Markdown
Contributor Author

/retest

@juanvallejo

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo

Copy link
Copy Markdown
Contributor Author

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit 06715e2 into openshift:release-3.7 Feb 9, 2018
openshift-merge-robot added a commit that referenced this pull request Feb 9, 2018
…imit-all

Automatic merge from submit-queue.

Backport origin pr 18219 limit all

Picks kubernetes/kubernetes#49624
Picks #18219

Depends on #18476

Addresses #18473 (comment)

cc @deads2k
@juanvallejo juanvallejo deleted the backport-origin-pr-18085-limit-all branch February 9, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants