Accept buildah 1.7.3+ unused build arg error#22641
Accept buildah 1.7.3+ unused build arg error#22641openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
Hopefully this helps with openshift/builder#65. |
Buildah 1.7.3 changed how it warns about unused build args, changing a "[Warning] One or more build-args %v were not consumed\n" format string into "[Warning] one or more build args were not consumed: %v\n". Accept either version. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
/lgtm Note that we'll want to drop the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM assuming happy tests. Thanks @nalind! |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws-builds |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Buildah 1.7.3 changed how it warns about unused build args, changing a
"[Warning] One or more build-args %v were not consumed\n"format string into"[Warning] one or more build args were not consumed: %v\n". Accept either version.