Skip to content

Accept buildah 1.7.3+ unused build arg error#22641

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
nalind:buildah-update
Apr 26, 2019
Merged

Accept buildah 1.7.3+ unused build arg error#22641
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
nalind:buildah-update

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Apr 23, 2019

Buildah 1.7.3 changed how it warns about unused build args, changing a "[Warning] One or more build-args %v were not consumed\n" format string into "[Warning] one or more build args were not consumed: %v\n". Accept either version.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2019
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Apr 23, 2019

Hopefully this helps with openshift/builder#65.

Buildah 1.7.3 changed how it warns about unused build args, changing a
"[Warning] One or more build-args %v were not consumed\n" format string
into "[Warning] one or more build args were not consumed: %v\n".  Accept
either version.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@adambkaplan
Copy link
Copy Markdown
Contributor

/lgtm

Note that we'll want to drop the Or logic once the bump on openshift/builder lands.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@TomSweeneyRedHat
Copy link
Copy Markdown

LGTM assuming happy tests. Thanks @nalind!

@adambkaplan
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Apr 24, 2019

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Apr 25, 2019

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rhatdan
Copy link
Copy Markdown
Contributor

rhatdan commented Apr 26, 2019

/test e2e-aws-builds

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f67078b into openshift:master Apr 26, 2019
@nalind nalind deleted the buildah-update branch May 8, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants