When no argument passed to oc adm release new, dry run the output#22693
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Apr 29, 2019
Merged
When no argument passed to oc adm release new, dry run the output#22693openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
The error message when an image-reference points to a non-existent image can be shortened and made more succinct since it is very common. Clean up the output of new to be easier to scan.
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Print an output consistent with oc adm release info --verify if no arguments are specified or if an image is pushed. Other modes bypass the image creation and so do not have this output. Make --dry-run on oc image append calculate the SHA instead of just doing nothing. Clean up some incremental output from append and in general make the entire experience more pleasant.
smarterclayton
force-pushed
the
messages
branch
from
b053e33 to
15292e0
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
Last piece required to audit releases. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print an output consistent with oc adm release info --verify if no
arguments are specified or if an image is pushed. Other modes bypass the
image creation and so do not have this output.
Make --dry-run on oc image append calculate the SHA instead of just doing
nothing.
Clean up some incremental output from append and in general make the entire
experience more pleasant.
Finally, perform a final step verification that a no-argument recreation
of the payload works correctly.