Skip to content

don't fight with CRDs for SCC and RBR#22721

Merged
deads2k merged 2 commits intoopenshift:masterfrom
deads2k:crd-fight
Apr 30, 2019
Merged

don't fight with CRDs for SCC and RBR#22721
deads2k merged 2 commits intoopenshift:masterfrom
deads2k:crd-fight

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 30, 2019

APIServices in openshift/cluster-config-operator#51 are fighting.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2019
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Apr 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 08f7ca0 link /test e2e-aws-upgrade
ci/prow/e2e-aws 08f7ca0 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 30, 2019

This is a core functionality concern that works or we wouldn't be able to create pods. Merging to unstick SCC.

@deads2k deads2k merged commit b73bbf3 into openshift:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants