SCC bootstrapping must not return until it has created all defaults#22732
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 1, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Contributor
Author
|
fun stuff. The creation of apiservices needs to come earlier. @sallyom can you fix it? |
deads2k
force-pushed
the
bootstrap-scc-fail
branch
from
41fda12 to
df4bbf5
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Contributor
Author
|
/test e2e-aws |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we end up having inconsistent bootstrapping behavior. By doing it in a loop, the healthz reports what we expect and we have a clear signal of failure before getting inconsistent results about which SCC have and have not been created.