switch leader election lock for ocm to openshift-controller-manager#22771
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom May 8, 2019
Merged
switch leader election lock for ocm to openshift-controller-manager#22771openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
Contributor
Author
|
@deads2k shot in the dark that maybe we weren't creating the openshift-controller-manager namespace in integration tests? |
Contributor
Author
|
@deads2k this seems promising...passed test/cmd anyway. |
bparees
force-pushed
the
leader
branch
2 times, most recently
from
a74eb16 to
db25eb7
Compare
openshift-ci-robot
removed
the
size/S
bparees
changed the title
openshift-ci-robot
added
size/M
bparees
force-pushed
the
leader
branch
3 times, most recently
from
ed42fd6 to
2c4d1b3
Compare
Closed
deads2k
reviewed
May 7, 2019
| // we should be seeing an "ADD" watch event being emitted, since we are specifically watching this project via a field selector | ||
| waitForAdd("ns-01", w, t) | ||
| // TODO: Something is modifying the project, someone should track down what. | ||
| waitForModified("ns-01", w, t) |
Contributor
There was a problem hiding this comment.
this should no longer be necessary. Removing it may prevent flakes since we don't know why it's timed this way at the moment.
Contributor
Author
There was a problem hiding this comment.
removed, will self-lgtm
Contributor
|
minor comment. lgtm otherwise /lgtm |
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
@adambkaplan fyi. this completes moving the openshift-controller-manager lease object into the openshift-controller-manager namespace instead of kube-system |
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
/retest
…On Tue, May 7, 2019 at 8:19 PM OpenShift CI Robot ***@***.***> wrote:
@bparees <https://github.com/bparees>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/integration f3be6c4
<f3be6c4>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/22771/pull-ci-openshift-origin-master-integration/6287> /test
integration
Full PR test history <https://openshift-gce-devel.appspot.com/pr/22771>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22771 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABF6LXXR2APA6E2YXSDI43DPUIMCTANCNFSM4HKWCY2A>
.
--
Ben Parees | OpenShift
|
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
|
/test e2e-aws-serial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.