Skip to content

Fix my github id in sdn-cni-plugin/OWNERS#22825

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:fix-cni-owners
May 14, 2019
Merged

Fix my github id in sdn-cni-plugin/OWNERS#22825
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:fix-cni-owners

Conversation

@danwinship
Copy link
Copy Markdown
Contributor

@danwinship danwinship commented May 13, 2019

No description provided.

@danwinship danwinship requested a review from dcbw May 13, 2019 11:36
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2019
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented May 13, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Copy Markdown
Member

wking commented May 13, 2019

/hold

This keeps dying with:

error: unable to create a release: operator "cluster-monitoring-operator" contained an invalid image-references file: no input image tag named "prometheus-operator"

Probably a cached broken run. Can you either delete the CI project for this PR or push a new commit timestamp or some such to get a new randomized CI project?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 14, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@danwinship danwinship added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 14, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4dfa913 into openshift:master May 14, 2019
@danwinship danwinship deleted the fix-cni-owners branch May 29, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc knobunc approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@squeed squeed Awaiting requested review from squeed

Assignees

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danwinship @dcbw @openshift-ci-robot @openshift-bot @wking @knobunc @openshift-merge-robot