Add serial tests for baremetal resources #26643

bfournie · 2021-11-28T22:47:03Z

Add new serial tests for hostfirmwaresettings:

A test to confirm invalid settings are handled properly
A test to change a setting and bring a worker through cleaning to confirm that new setting is reflected in the BMC, using BMC emulator (sushy)

bfournie · 2021-11-29T12:43:11Z

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-aws-serial
/test e2e-aws-single-node

bfournie · 2021-11-29T16:27:13Z

/test e2e-metal-ipi-ovn-ipv6
/test e2e-aws-serial
/test e2e-aws-single-node

bfournie · 2021-11-30T00:06:30Z

/test e2e-metal-ipi-ovn-ipv6
/test e2e-aws-serial
/test e2e-aws-single-node

bfournie · 2021-11-30T12:39:46Z

/test e2e-metal-serial
/test e2e-metal-ipi-ovn-ipv6

bfournie · 2021-11-30T13:27:03Z

/test e2e-metal-ipi-serial

bfournie · 2021-12-13T19:38:27Z

/test e2e-metal-serial
/test e2e-metal-ipi-ovn-ipv6

bfournie · 2021-12-16T12:50:58Z

/test e2e-aws-serial

bfournie · 2021-12-16T12:51:38Z

/hold

bfournie · 2021-12-16T16:02:22Z

This PR will be redone using extra workers after #26681 merges

bfournie · 2021-12-19T00:05:27Z

/test e2e-metal-serial
/test e2e-metal-ipi-ovn-ipv6

ardaguclu

That looks good to me. Just a few comments

ardaguclu · 2022-02-09T06:18:43Z

test/extended/baremetal/hosts.go

+
+		// Deploy extra worker and wait
+		host, _ := helper.CreateExtraWorker(hostData, secretData)
+		host = helper.WaitForProvisioningState(host, "available")


I think, helper.DeployExtraWorker does the same thing above 3 lines do.

Thanks Arda, good point. I will change to use DeployExtraWorker.

test/extended/baremetal/hosts.go

ardaguclu · 2022-02-10T07:04:10Z

/test e2e-metal-ipi-serial

ardaguclu · 2022-02-10T08:28:44Z

/test e2e-metal-ipi-serial

elfosardo · 2022-08-01T09:18:05Z

/lgtm

elfosardo · 2022-08-01T09:18:12Z

/test e2e-metal-ipi-ovn-ipv6

hroyrh · 2022-08-02T17:00:58Z

/assign @celebdor
can you please take a look and approve if everything looks okay

Add new serial tests for hostfirmwaresettings: - A test to confirm invalid settings are handled properly - A test to change a setting and bring a worker through cleaning to confirm that new setting is reflected in the BMC, using BMC emulator (sushy)

openshift-ci · 2022-09-01T11:27:19Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2022-09-01T11:31:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie, elfosardo
Once this PR has been reviewed and has the lgtm label, please ask for approval from celebdor by writing /assign @celebdor in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

~~test/extended/baremetal/OWNERS~~ [bfournie,elfosardo]
test/extended/util/annotate/generated/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hroyrh · 2022-09-02T03:08:01Z

/test e2e-metal-ipi-serial

dtantsur · 2022-09-05T06:46:45Z

test/extended/baremetal/hosts.go

+
+		dc := oc.AdminDynamicClient()
+
+		// Deploy extra worker and wait for it to be available


Are we sure it's always redfish, never ipmi?

openshift-merge-robot · 2022-10-12T13:21:28Z

@bfournie: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-04T22:15:53Z

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node-upgrade	`25f711c`	link	false	`/test e2e-aws-single-node-upgrade`
ci/prow/e2e-aws-single-node	`25f711c`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-gcp-upgrade	`25f711c`	link	true	`/test e2e-gcp-upgrade`
ci/prow/e2e-aws-ovn-cgroupsv2	`6bfe93a`	link	false	`/test e2e-aws-ovn-cgroupsv2`
ci/prow/e2e-aws-ovn-fips	`6bfe93a`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/verify	`6bfe93a`	link	true	`/test verify`
ci/prow/e2e-agnostic-ovn-cmd	`6bfe93a`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-aws-ovn-serial	`6bfe93a`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/e2e-gcp-ovn-rt-upgrade	`6bfe93a`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-ovn-single-node-upgrade	`6bfe93a`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-gcp-builds	`6bfe93a`	link	true	`/test e2e-gcp-builds`
ci/prow/e2e-gcp-ovn-upgrade	`6bfe93a`	link	true	`/test e2e-gcp-ovn-upgrade`
ci/prow/unit	`6bfe93a`	link	true	`/test unit`
ci/prow/e2e-aws-ovn-image-registry	`6bfe93a`	link	true	`/test e2e-aws-ovn-image-registry`
ci/prow/e2e-gcp-ovn-builds	`6bfe93a`	link	true	`/test e2e-gcp-ovn-builds`
ci/prow/e2e-gcp-ovn-image-ecosystem	`6bfe93a`	link	true	`/test e2e-gcp-ovn-image-ecosystem`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-02-03T09:00:23Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-03-06T00:30:47Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-04-05T08:00:15Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-04-05T08:01:18Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from deads2k and smarterclayton November 28, 2021 22:49

bfournie force-pushed the bm-hfs-serial-tests branch from 2cd9e16 to 972cdc5 Compare November 29, 2021 01:22

bfournie force-pushed the bm-hfs-serial-tests branch from 972cdc5 to e538aa0 Compare November 29, 2021 18:33

bfournie force-pushed the bm-hfs-serial-tests branch from e538aa0 to 58e858d Compare December 15, 2021 14:41

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021

andfasano mentioned this pull request Jan 12, 2022

Bug 2040741: Allow baremetal tests to run on multiple platforms #26660

Merged

bfournie force-pushed the bm-hfs-serial-tests branch from 58e858d to e920805 Compare January 26, 2022 21:09

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022

bfournie force-pushed the bm-hfs-serial-tests branch from e920805 to 9d5e001 Compare January 29, 2022 17:00

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2022

bfournie force-pushed the bm-hfs-serial-tests branch from 9d5e001 to 999cb99 Compare February 7, 2022 23:19

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2022

bfournie force-pushed the bm-hfs-serial-tests branch from 999cb99 to 1946aeb Compare February 7, 2022 23:51

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2022

ardaguclu reviewed Feb 9, 2022

View reviewed changes

bfournie force-pushed the bm-hfs-serial-tests branch from 1946aeb to 22081a2 Compare February 9, 2022 21:19

bfournie force-pushed the bm-hfs-serial-tests branch from 22081a2 to 3ed09cb Compare February 10, 2022 17:43

openshift-ci bot assigned elfosardo Aug 1, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022

openshift-ci bot assigned celebdor Aug 2, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2022

bfournie and others added 5 commits September 1, 2022 07:25

move setting validation check after the correct value is set

053b7b9

minor fixes

a028df0

minor fixes, debug messages

50a28d0

minor fixes

6bfe93a

hroyrh force-pushed the bm-hfs-serial-tests branch from 25f711c to 6bfe93a Compare September 1, 2022 11:27

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022

dtantsur reviewed Sep 5, 2022

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 6, 2023

openshift-ci bot closed this Apr 5, 2023


		dc := oc.AdminDynamicClient()

		// Deploy extra worker and wait for it to be available

Add serial tests for baremetal resources #26643

Add serial tests for baremetal resources #26643

Uh oh!

Conversation

bfournie commented Nov 28, 2021

Uh oh!

bfournie commented Nov 29, 2021

Uh oh!

bfournie commented Nov 29, 2021

Uh oh!

bfournie commented Nov 30, 2021

Uh oh!

bfournie commented Nov 30, 2021

Uh oh!

bfournie commented Nov 30, 2021

Uh oh!

bfournie commented Dec 13, 2021

Uh oh!

bfournie commented Dec 16, 2021

Uh oh!

bfournie commented Dec 16, 2021

Uh oh!

bfournie commented Dec 16, 2021

Uh oh!

bfournie commented Dec 19, 2021

Uh oh!

ardaguclu left a comment

Choose a reason for hiding this comment

Uh oh!

ardaguclu Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

bfournie Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ardaguclu commented Feb 10, 2022

Uh oh!

ardaguclu commented Feb 10, 2022

Uh oh!

elfosardo commented Aug 1, 2022

Uh oh!

elfosardo commented Aug 1, 2022

Uh oh!

hroyrh commented Aug 2, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022

Uh oh!

hroyrh commented Sep 2, 2022

Uh oh!

dtantsur Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

openshift-merge-robot commented Oct 12, 2022

Uh oh!

openshift-ci bot commented Nov 4, 2022

Uh oh!

openshift-bot commented Feb 3, 2023

Uh oh!

openshift-bot commented Mar 6, 2023

Uh oh!

openshift-bot commented Apr 5, 2023

Uh oh!

openshift-ci bot commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants