NO-ISSUE: Skip additional storage support E2E test for on single-node - MCP rollouts timeout

[BhargaviGudi]

Skip additional storage support E2E test for on single-node - MCP rollouts timeout
MCP rollouts don't work reliably on single-node clusters. The test creates a custom MCP which triggers node drains, but single-node cannot drain its only control plane node without bringing down the cluster (context deadline exceeded).

Added [Skipped:SingleReplicaTopology] tag

Summary by CodeRabbit

• Tests
  • Updated the Additional Storage end-to-end test suite to skip automatically in single-replica environments.
  • Documented limitations related to MCP rollout timeouts and node-drain operations on single-node clusters.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[BhargaviGudi]

@saschagrunert @cpmeadors Could you please help to review this PR? Thanks

[coderabbitai]

Walkthrough

The additional storage E2E test suite is tagged to skip SingleReplicaTopology environments, with comments documenting MCP rollout timeouts and node-drain limitations on single-node clusters.

Changes

Additional Storage E2E

Layer / File(s)	Summary
Skip unsupported topology test/extended/node/additional_storage_e2e.go	Adds the [Skipped:SingleReplicaTopology] tag and documents why the suite cannot run on single-node clusters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openshift/origin#31399: Introduced the additional storage E2E test that this change updates.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only Ginkgo titles in the changed file are static strings; the PR only adds a skip tag and comments, with no dynamic test names.
Test Structure And Quality	✅ Passed	The change only adds a skip tag/comment; the test already uses BeforeEach/DeferCleanup and explicit timeouts, with no new structural or cleanup regressions.
Microshift Test Compatibility	✅ Passed	The test already has [apigroup:config.openshift.io] and [apigroup:machineconfiguration.openshift.io] labels plus SkipOnMicroShift(), so MicroShift jobs skip it.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The test is wrapped in a Describe tagged [Skipped:SingleReplicaTopology], which explicitly exempts it from SNO per the check.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: PR only adds a Ginkgo skip tag/comment to an E2E test; it doesn't add manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PASS: The diff only adds a Ginkgo skip tag/comment in an existing test file; no suite-level stdout writes or logging changes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only adds a skip tag/comment; the suite is already [Skipped:Disconnected], and I found no IPv4-specific address handling.
No-Weak-Crypto	✅ Passed	Touched test file only adds a skip tag/comment; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges	✅ Passed	Only a Go Ginkgo skip-tag/comment change; no container/K8s manifests or privileged settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds a skip tag and comments; no new logging or sensitive-data exposure was introduced in the changed file.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: skipping the additional storage E2E test on single-node clusters due to MCP rollout timeouts.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[BhargaviGudi]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-single-node-disruptive-longrunning-techpreview-1of2

[openshift-ci]

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-single-node-disruptive-longrunning-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/125c6c90-8a80-11f1-8065-78abcd71def3-0

[openshift-ci-robot]

@BhargaviGudi: This pull request explicitly references no jira issue.

Details

In response to this:

Skip additional storage support E2E test for on single-node - MCP rollouts timeout
MCP rollouts don't work reliably on single-node clusters. The test creates a custom MCP which triggers node drains, but single-node cannot drain its only control plane node without bringing down the cluster (context deadline exceeded).

Added [Skipped:SingleReplicaTopology] tag

Summary by CodeRabbit

• Tests
• Updated the Additional Storage end-to-end test suite to skip automatically in single-replica environments.
• Documented limitations related to MCP rollout timeouts and node-drain operations on single-node clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cpmeadors]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BhargaviGudi, cpmeadors, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/node/OWNERS [cpmeadors]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BhargaviGudi]

/verified by @BhargaviGudi Added [Skipped:SingleReplicaTopology] tag to skip e2e tests on single node clusters

[openshift-ci-robot]

@BhargaviGudi: This PR has been marked as verified by @BhargaviGudi Added [Skipped:SingleReplicaTopology] tag to skip e2e tests on single node clusters``.

Details

In response to this:

/verified by @BhargaviGudi Added [Skipped:SingleReplicaTopology] tag to skip e2e tests on single node clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@BhargaviGudi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.