Remove exceptions OCPBUGS-42837 and OCPBUGS-64852

[hongkailiu]

They are fixed in 5.0.

• https://redhat.atlassian.net/browse/OCPBUGS-42837?focusedCommentId=17817891

• https://redhat.atlassian.net/browse/OCPBUGS-64852?focusedCommentId=17817896

/hold

wait for 5.1 cut.

Summary by CodeRabbit

• Bug Fixes
  • Operator transition checks now correctly report SyncingFailed conditions without treating the cloud controller manager as an exception.
  • Applied consistently across stable, upgrade, and progressing-state checks.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

The change removes the cloud-controller-manager SyncingFailed exception from stable, upgrade, and progressing-state transition checks.

Changes

Cluster version operator transition checks

Layer / File(s)	Summary
Remove transition exceptions pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Stable, upgrade, and progressing-state checks no longer exempt cloud-controller-manager SyncingFailed conditions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch only removes three exception branches. It adds no test titles, and existing JUnit names use stable operator and condition identifiers rather than run-generated values.
Test Structure And Quality	✅ Passed	The commit only removes three exception branches. The changed file generates JUnit cases from events and has no Ginkgo It blocks, resource creation, cleanup, Eventually, or Consistently calls.
Microshift Test Compatibility	✅ Passed	The PR only deletes nine existing exception branches in operators.go; it adds no Ginkgo tests or new API/feature references, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request only deletes three exception blocks from operators.go; it adds no new Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The only change is in a monitor-test file and removes three SyncingFailed exceptions; it adds no manifests, controllers, replicas, affinity, selectors, tolerations, or topology constraints.
Ote Binary Stdout Contract	✅ Passed	The commit only deletes three exception blocks; it adds no main/init/suite setup, stdout writes, klog calls, or logging configuration changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit only deletes three exception blocks from operators.go; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit only deletes three operator-condition exception branches; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The PR changes only nine deleted lines in a Go monitor test. The diff adds no container or Kubernetes manifest privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The parent-to-HEAD diff contains only nine deleted exception lines and adds no logging or sensitive-data output.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the removal of the two issue-related exceptions, which matches the main change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	96a8571	link	true	/test e2e-vsphere-ovn-upi
ci/prow/e2e-metal-ipi-ovn-ipv6	96a8571	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-microshift-serial	96a8571	link	true	/test e2e-aws-ovn-microshift-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.