TRT-2939: Revert "Merge pull request #31495 from jcmoraisjr/NE-2839-haproxy-version-upgrade-tests" - #31598
Conversation
…NE-2839-haproxy-version-upgrade-tests" This reverts commit 5e2b66a, reversing changes made to bd31098. Reverting PR openshift#31495 (NE-2839: Add HAProxy version upgrade tests) which introduced breaking test failures. Tracked in TRT-2939.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
Bot
added
the
ready-for-human-review
openshift-ci-robot
added
the
jira/valid-reference
|
@redhat-chai-bot: This pull request references TRT-2939 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe legacy HAProxy upgrade test suite was removed. Multi-HAProxy tests now derive supported versions from controller status, manage readiness inline, validate effective versions, and inspect runtime HAProxy in the ChangesHAProxy upgrade test consolidation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change reverts the HAProxy version upgrade tests and removes the reported HyperShift test failure path; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
Full details: Stable And Deterministic Test NamesExplanation PASS. The changed Ginkgo titles in Full details: Test Structure And QualityExplanation The PR introduces assertion-message violations in Resolution Add meaningful context to every new or changed assertion. Include the controller name and operation for cleanup, API-client creation, CRD retrieval, default-controller retrieval, and effective-version comparison. Restore a diagnostic message for the runtime HAProxy-version assertion, such as Full details: Microshift Test CompatibilityExplanation No new Ginkgo test declarations were added. The parent and current Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS — The pull request adds no new Ginkgo test declarations. The five Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only end-to-end test code. It removes HAProxy upgrade test registrations and a deleted upgrade-test implementation. The remaining Full details: Ote Binary Stdout ContractExplanation PASS. The pull request introduces no process-level stdout write. It removes three upgrade test registrations and deletes the HAProxy upgrade file. In Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS. The pull request adds no new Ginkgo test declarations. The five Full details: No-Weak-CryptoExplanation PASS. The commit changes test registration and HAProxy version test plumbing only. The added code has no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, crypto, HMAC, or constant-time comparison usage. Its string comparison checks a public HAProxy version, not a secret or token. The deleted test cannot introduce weak crypto. Full details: Container-PrivilegesExplanation PASS: The PR changes only three Go test files. The exact diff contains no Full details: No-Sensitive-Data-In-LogsExplanation PASS — The pull request does not introduce sensitive-data logging. The added log statements report IngressController names and HAProxy version values only. The runtime command captures HAProxy
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/override ci/prow/e2e-aws-ovn-upgrade-rollback |
|
@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-aws-ovn-upgrade-rollback, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redhat-chai-bot, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@xueqzhan: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Revert of #31495
This reverts the merge commit for PR #31495 (NE-2839: Add HAProxy version upgrade tests).
Why
PR #31495 introduced a
getHAProxyVersionConfig()helper that callsDeployments("openshift-ingress-operator").Get(…, "ingress-operator")in the guest cluster. In HyperShift topologies the ingress-operator runs in the management cluster, so the Get returns a 404 unconditionally. This fails 5IngressControllerMultipleHAProxyVersionstests inBeforeEach, breaking all HyperShift conformance jobs.Impact
5.1.0-0.nightly-2026-09-02-124257— 11 of 16 blocking jobs failed (10 new failures)aggregated-hypershift-ovn-conformance-5.1,aggregated-hypershift-aks-conformance-5.1References
AI-generated. Review for accuracy.
@xueqzhan requested in Slack thread
Summary by CodeRabbit