OCPSTRAT-3618: Update etcd test data for k8s 1.37 release

[jubittajohn]

Summary by CodeRabbit

• Tests
  • Expanded Kubernetes minor version 37 storage-path validation to cover newly introduced resource types.
  • Added coverage for storage version migrations, scheduling, certificates, evictions, lifecycle resources, and admission registration policies.
  • Updated expected version and resource mappings to verify correct storage behavior for newly introduced, modified, and removed resource versions.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jubittajohn: This pull request references OCPSTRAT-3618 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 35359e58-cfb5-4d69-8d4d-8c140bcacce0

📥 Commits

Reviewing files that changed from the base of the PR and between e0a97b3 and 6ad4c04.

📒 Files selected for processing (1)

• test/extended/etcd/etcd_storage_path.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The etcd storage-path test now includes Kubernetes 1.37 fixtures for new and modified resources. The fixtures define expected storage paths, GVKs, and resource version lifecycle metadata.

Changes

Etcd storage-path coverage

Layer / File(s)	Summary
Kubernetes 1.37 storage fixtures test/extended/etcd/etcd_storage_path.go	Adds storage definitions and expected paths for new resources. Adds version-specific mappings for modified resources, including introduction and removal versions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6ad4c

This updates etcd storage-path expectations for Kubernetes 1.37 resources without changing production behavior. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only etcd storage test data in test/extended/etcd/etcd_storage_path.go. The diff adds no It, Describe, Context, When, or other test-title declaration. The encl…
Test Structure And Quality	✅ Passed	The pull request adds only versioned etcd fixture data in test/extended/etcd/etcd_storage_path.go. It adds no It, BeforeEach, AfterEach, Eventually, Consistently, assertion, or cluster-ope…
Microshift Test Compatibility	✅ Passed	PASS — The pull request changes only test/extended/etcd/etcd_storage_path.go and adds storage-data entries inside the existing testEtcd3StoragePath test. The diff adds no It(), Describe(), `Co…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only test/extended/etcd/etcd_storage_path.go and adds declarative etcd StorageData entries. It adds no new It(), Describe(), Context(), or When() test. The e…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The commit changes only test/extended/etcd/etcd_storage_path.go. The additions are etcddata.StorageData fixtures with stubs, GVKs, paths, and version metadata. No deployment manifest, operat…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only test/extended/etcd/etcd_storage_path.go. All added code is storage-test data inside testEtcd3StoragePath, which runs from an It body. The diff adds no `fmt.Pr…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The commit changes only versioned etcd storage-data entries in test/extended/etcd/etcd_storage_path.go (+132/-1). It does not add It, Describe, Context, or When nodes. The existing ser…
No-Weak-Crypto	✅ Passed	The pull request adds only etcd storage-test fixtures in test/extended/etcd/etcd_storage_path.go. It adds no crypto implementation, cipher call, token comparison, or secret comparison. The embedded …
Container-Privileges	✅ Passed	PASS: The pull request changes only test/extended/etcd/etcd_storage_path.go. The added content is Go test data for etcd resource objects and contains no container or Kubernetes manifest privilege se…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The pull request adds static etcd test fixtures only. It adds no logging calls or log-format changes. The added certificate, public-key, and proof-of-possession values are test cryptographic mat…
Title check	✅ Passed	The title clearly and concisely describes the main change: updating etcd test data for the Kubernetes 1.37 release. The Jira issue reference adds useful tracking context.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only etcd storage test data in test/extended/etcd/etcd_storage_path.go. The diff adds no It, Describe, Context, When, or other test-title declaration. The enclosing Ginkgo title remains should be stored at the correct location and version for all resources [Serial]. The added names, UIDs, node values, and namespace-based paths occur in test data and expected-path bodies, not test titles.

Full details: Test Structure And Quality

Explanation

The pull request adds only versioned etcd fixture data in test/extended/etcd/etcd_storage_path.go. It adds no It, BeforeEach, AfterEach, Eventually, Consistently, assertion, or cluster-operation code. The existing resource loop tracks created objects and defers cleanup through allClient.cleanup; the suite also registers cli.TeardownProject with AfterEach. Existing assertion and timeout patterns are unchanged. The added fixtures therefore introduce no explicit Test Structure and Quality failure.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request changes only test/extended/etcd/etcd_storage_path.go and adds storage-data entries inside the existing testEtcd3StoragePath test. The diff adds no It(), Describe(), Context(), or When() declaration. The new resources use standard Kubernetes API groups such as resource.k8s.io, certificates.k8s.io, and scheduling.k8s.io; no new MicroShift-unavailable OpenShift API reference or unsupported assumption is introduced.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only test/extended/etcd/etcd_storage_path.go and adds declarative etcd StorageData entries. It adds no new It(), Describe(), Context(), or When() test. The existing Ginkgo test and its [Serial] label are unchanged. The added data contains no multi-node or HA test assumptions such as node counting, affinity, failover, scaling, or rescheduling.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS. The commit changes only test/extended/etcd/etcd_storage_path.go. The additions are etcddata.StorageData fixtures with stubs, GVKs, paths, and version metadata. No deployment manifest, operator, controller, pod scheduling constraint, replica setting, node selector, affinity, toleration, topology spread constraint, or PDB was added or modified. The check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request changes only test/extended/etcd/etcd_storage_path.go. All added code is storage-test data inside testEtcd3StoragePath, which runs from an It body. The diff adds no fmt.Print*, log.Print*, klog, os.Stdout, Ginkgo suite setup, or top-level initializer writes. The existing fmt.Sprintf call only formats data.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The commit changes only versioned etcd storage-data entries in test/extended/etcd/etcd_storage_path.go (+132/-1). It does not add It, Describe, Context, or When nodes. The existing serial Ginkgo test remains unchanged in etcd_test_runner.go and invokes the helper. The added values contain no IPv4 literals, IP parsing, URL construction, DNS lookup, or external connection. The example.com and similar strings are object stub fields and expected etcd paths, not network destinations.

Full details: No-Weak-Crypto

Explanation

The pull request adds only etcd storage-test fixtures in test/extended/etcd/etcd_storage_path.go. It adds no crypto implementation, cipher call, token comparison, or secret comparison. The embedded certificate, CSR, and public-key fixtures use OID 1.3.101.112 (Ed25519), not MD5, SHA1, DES, RC4, 3DES, Blowfish, or ECB mode.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only test/extended/etcd/etcd_storage_path.go. The added content is Go test data for etcd resource objects and contains no container or Kubernetes manifest privilege settings. The added-line search found no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or runAs* markers. Therefore, no stated container-privilege failure condition was introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request adds static etcd test fixtures only. It adds no logging calls or log-format changes. The added certificate, public-key, and proof-of-possession values are test cryptographic material with no private key. The names and domains use synthetic values such as example.com, foo.com, and test.example.com. Existing error logging can report test failures, but the pull request does not add passwords, tokens, API keys, PII, internal hostnames, or customer data to those logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jubittajohn]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2 openshift/kubernetes#2738

[openshift-ci]

@jubittajohn: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4535d750-a7bd-11f1-9b6e-0dc5280af704-0

[jubittajohn]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[jubittajohn]

/retest-required

[jubittajohn]

/retest-required

[jacobsee]

/lgtm

[jacobsee]

/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsee, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/etcd/OWNERS [jubittajohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jubittajohn]

/retest-required

[jubittajohn]

/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-kubernetes-2738-openshift-origin-31605-nightly-5.0-e2e-aws-ovn-serial-1of2/2095565345430441984

[openshift-ci-robot]

@jubittajohn: This PR has been marked as verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-kubernetes-2738-openshift-origin-31605-nightly-5.0-e2e-aws-ovn-serial-1of2/2095565345430441984.

Details

In response to this:

/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-kubernetes-2738-openshift-origin-31605-nightly-5.0-e2e-aws-ovn-serial-1of2/2095565345430441984

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.