Skip to content

OCPBUGS-66213: add link to jira card - #31609

Open
ricardomaraschini wants to merge 1 commit into
openshift:mainfrom
ricardomaraschini:OCPBUGS-66213-3
Open

OCPBUGS-66213: add link to jira card#31609
ricardomaraschini wants to merge 1 commit into
openshift:mainfrom
ricardomaraschini:OCPBUGS-66213-3

Conversation

@ricardomaraschini

@ricardomaraschini ricardomaraschini commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

make sure the exception links to a jira card.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the single-replica image registry exception guidance to provide a direct reference to the relevant issue.
    • Replaced the previous platform-specific manual-configuration message with the issue URL, giving users a more appropriate resource when this exception is encountered.

make sure the exception links to a jira card.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@ricardomaraschini: This pull request references Jira Issue OCPBUGS-66213, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

make sure the exception links to a jira card.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e8869a1a-c948-45cc-bc1a-f34e4991dfab

📥 Commits

Reviewing files that changed from the base of the PR and between ca3df39 and 5fbecf0.

📒 Files selected for processing (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The image-registry single-replica exception now reports the OCPBUGS-66213 issue URL instead of a platform-specific manual-configuration message.

Changes

Image registry exception

Layer / File(s) Summary
Update exception issue reporting
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
The tolerated single-replica exception now returns the OCPBUGS-66213 issue URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5fbec

This change replaces the image-registry single-replica exception message with a Jira link. No concrete current-head implementation risk remains established.

Suggested reviewers: hongkailiu, eggfoobar, pskrbasu

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding a link to Jira card OCPBUGS-66213. It is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only an exception string in testUpgradeOperatorStateTransitions. The new Jira URL is static and is written to exception/failure output, not to a Ginkgo or JUnit test t…
Test Structure And Quality ✅ Passed PASS: The pull request changes one return string in operators.go, from a platform-specific message to the OCPBUGS-66213 Jira URL. It adds no Ginkgo It block, resource setup, cleanup, cluster wait,…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes one return string in the existing testUpgradeOperatorStateTransitions helper. It adds no It(), Describe(), Context(), or When() test. It introduces no MicroShi…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes one exception message in an existing cluster-version monitor test. The diff adds no Ginkgo e2e tests or test constructs such as It(), Describe(), Context(), or `Wh…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only the exception message in pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go. It replaces a platform-specific string with the Jira URL `ht…
Ote Binary Stdout Contract ✅ Passed The pull request changes only one returned string in testUpgradeOperatorStateTransitions: it replaces a manual-configuration message with the Jira URL `https://redhat.atlassian.net/browse/OCPBUGS-66…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes one existing exception return value from a manual-configuration message to the Jira URL https://redhat.atlassian.net/browse/OCPBUGS-66213. The committed diff adds no G…
No-Weak-Crypto ✅ Passed PASS. The pull request changes one return value in operators.go: it replaces a descriptive exception message with the Jira URL https://redhat.atlassian.net/browse/OCPBUGS-66213. The added lines co…
Container-Privileges ✅ Passed PASS: The pull request changes only one Go return value in operators.go, from a descriptive message to the Jira URL https://redhat.atlassian.net/browse/OCPBUGS-66213. The commit changes no contain…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes one exception return value from a platform message to the Jira URL https://redhat.atlassian.net/browse/OCPBUGS-66213. It does not add logging or sensitive values. Exis…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deads2k and sjenning September 4, 2026 11:49
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Sep 4, 2026

@bertinatto bertinatto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2026
@bertinatto

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@bertinatto: This pull request references Jira Issue OCPBUGS-66213, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bertinatto: This pull request references Jira Issue OCPBUGS-66213, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (xiuwang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@ricardomaraschini: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants