Skip to content

UPSTREAM: 11694: http proxy support for exec/pf#5397

Merged
openshift-bot merged 1 commit into
openshift:masterfrom
ncdc:exec-proxy
Oct 26, 2015
Merged

UPSTREAM: 11694: http proxy support for exec/pf#5397
openshift-bot merged 1 commit into
openshift:masterfrom
ncdc:exec-proxy

Conversation

@ncdc

@ncdc ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Pull in support for http proxy with exec/attach/port forward that just missed the last rebase by a few hours. Note, this only pulls in the pkg file. The other changes in 11694 are all e2e test related, and they're not 100% correct and had to be corrected in a series of follow-ups, so I chose not to include any of that here. They can come in with the next rebase, if that's ok.

@sdodson @deads2k @liggitt @smarterclayton @brenton

@pweil- pweil- mentioned this pull request Oct 26, 2015
@liggitt

liggitt commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Is this the latest state of the spdy roundtripper upstream including any follow-up fixes? If so, LGTM

@ncdc

ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

@liggitt I diffed w/the upstream file and it came out clean.

@ncdc

ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

After spending 15 minutes trying to figure out why hack/cherry-pick.sh wasn't working (#5395), I gave up and did it by hand...

@ncdc

ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

[test]

@openshift-bot

Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6164/)

@openshift-bot

Copy link
Copy Markdown
Contributor

Evaluated for origin test up to 5f9ae44

@ncdc

ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

[merge]

@openshift-bot

Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3774/) (Image: devenv-rhel7_2564)

@openshift-bot

Copy link
Copy Markdown
Contributor

Evaluated for origin merge up to 5f9ae44

@smarterclayton

Copy link
Copy Markdown
Contributor

Probably because it's already merged?

On Oct 26, 2015, at 9:33 AM, Andy Goldstein notifications@github.com
wrote:

After spending 15 minutes trying to figure out why hack/cherry-pick.sh
wasn't working (#5395 #5395), I
gave up and did it by hand...


Reply to this email directly or view it on GitHub
#5397 (comment).

@ncdc

ncdc commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

It merged upstream, but a few hours after we started our rebase, so it missed getting into origin with the rebase. The problem is cherry-pick.sh doesn't support binary diffs for git apply. I have an open PR to fix that.

openshift-bot pushed a commit that referenced this pull request Oct 26, 2015
@openshift-bot openshift-bot merged commit 391a4df into openshift:master Oct 26, 2015
@ncdc ncdc mentioned this pull request Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants