ImageStreamImage returns incorrect image info#6945
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Feb 2, 2016
Merged
ImageStreamImage returns incorrect image info#6945openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Go range variable can't be the value we take a reference to.
Contributor
Author
Contributor
There was a problem hiding this comment.
do you need to do the same thing to avoid sharing history?
Contributor
Author
There was a problem hiding this comment.
History has a pointer to a slice of items, so no.
|
LGTM |
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4820/) (Image: devenv-rhel7_3307) |
Contributor
|
Evaluated for origin merge up to ba19b8e |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
Author
|
[test] |
1 similar comment
Contributor
Author
|
[test] |
Contributor
|
Evaluated for origin test up to ba19b8e |
Contributor
|
continuous-integration/openshift-jenkins/test ABORTED (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/685/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go range variable can't be the value we take a reference to.
Fixes #6919
@brenton this is a 3.1.1.1 candidate fix as well as 1.1.1.2