Skip to content

Set service account correctly in oadm registry, deprecate --credentials#8296

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
liggitt:registry-service-account
Mar 30, 2016
Merged

Set service account correctly in oadm registry, deprecate --credentials#8296
openshift-bot merged 1 commit intoopenshift:masterfrom
liggitt:registry-service-account

Conversation

@liggitt
Copy link
Copy Markdown
Contributor

@liggitt liggitt commented Mar 30, 2016

Fixes #8285

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Mar 30, 2016

[test]
@smarterclayton PTAL

@smarterclayton
Copy link
Copy Markdown
Contributor

@aweiteka please take a look at the atomic-quickstart changes

set -x

$CMD oadm registry --credentials /etc/origin/master/openshift-registry.kubeconfig
$CMD oadm registry
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per pending PR #8245 this dir was moved to examples/atomic-registry-quickstart

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweiteka can you make the atomic example changes in your PR, and I'll remove them from this one, then?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Mar 30, 2016

removed atomic changes, updated install_router to not pre-create the service account which oadm router will now attempt to create

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin test up to 641067b

@smarterclayton
Copy link
Copy Markdown
Contributor

LGTM

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2600/)

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Mar 30, 2016

[merge]

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2600/) (Image: devenv-rhel7_3871)

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin merge up to 641067b

@openshift-bot openshift-bot merged commit 349b21e into openshift:master Mar 30, 2016
@0xmichalis
Copy link
Copy Markdown
Contributor

This also needs a doc PR

@liggitt liggitt deleted the registry-service-account branch April 1, 2016 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants