add labels and annotations from buildrequest to resulting build#8405
add labels and annotations from buildrequest to resulting build#8405openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
pkg/build/generator/generator.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // add labels and annotations |
There was a problem hiding this comment.
comment why the build annotations take priority
There was a problem hiding this comment.
yeah just completed that comment, was a premature push. sorry.
|
@openshift/api-review ptal, i've chosen the approach of reusing the labels/annotations from the buildrequest, rather than adding new fields to the buildrequest struct. This seemed reasonable since the buildrequest itself is not a resource that gets stored/queried/etc, so its label/annotation fields serve no purpose. @mfojtik ptal |
bparees
force-pushed
the
annotations
branch
2 times, most recently
from
ae92176 to
92ecffb
Compare
|
[test] |
|
@mfojtik @openshift/api-review bump |
|
Review for 1.2 or later?
|
|
@smarterclayton post 3.2. |
pkg/build/generator/generator.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // add labels and annotations from the buildrequest. existing label/annotations will take |
There was a problem hiding this comment.
changed.
On Tue, Apr 12, 2016 at 3:49 AM, Michal Fojtik notifications@github.com
wrote:
In pkg/build/generator/generator.go
#8405 (comment):@@ -235,6 +236,11 @@ func (g *BuildGenerator) Instantiate(ctx kapi.Context, request *buildapi.BuildRe
return nil, err
}
- // add labels and annotations from the buildrequest. existing label/annotations will take
nit: capitalize 'Add' ;-)
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/8405/files/92ecffb3fe73de3f18a98486624aacf1c313df1b#r59333822
Ben Parees | OpenShift
|
LGTM |
|
Evaluated for origin test up to efbbf67 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2923/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2923/) (Image: devenv-rhel7_4039) |
|
Evaluated for origin merge up to efbbf67 |
5 participants
fixes #8352