Skip to content

Reorganize the image package, make it match upstream patterns#85

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
smarterclayton:refactor_image_dirs
Sep 15, 2014
Merged

Reorganize the image package, make it match upstream patterns#85
openshift-bot merged 1 commit intoopenshift:masterfrom
smarterclayton:refactor_image_dirs

Conversation

@smarterclayton
Copy link
Contributor

  • Storage -> REST
  • Folders a bit more organized

* Storage -> REST
* Folders a bit more organized
@smarterclayton
Copy link
Contributor Author

@mfojtik/@VojtechVitek can you review (and also do this to templates and config to match)?

@soltysh
Copy link
Contributor

soltysh commented Sep 15, 2014

LGTM 👍
I'd also propose changing builds to follow the same patterns:

  • Storage -> REST
  • etcdregistry.go into separate folder
    @csrwng can you handle that one or can I do it?

@smarterclayton smarterclayton mentioned this pull request Sep 15, 2014
@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/94/) (Image: devenv-fedora_161)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 3c68b93

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 'a Registry'

openshift-bot pushed a commit that referenced this pull request Sep 15, 2014
@openshift-bot openshift-bot merged commit 2647df5 into openshift:master Sep 15, 2014
@VojtechVitek
Copy link
Contributor

LGTM

ironcladlou pushed a commit to ironcladlou/origin that referenced this pull request Oct 15, 2014
@smarterclayton smarterclayton deleted the refactor_image_dirs branch May 18, 2015 02:16
deads2k referenced this pull request in deads2k/origin May 17, 2016
danwinship pushed a commit to danwinship/origin that referenced this pull request Jun 24, 2016
sdn should not re-configure docker/ovs if it appears to be a harmless restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants